Bug 205528 - LegacyInlineTextBox::selectionState accessor mutates ellipsis selection state
Summary: LegacyInlineTextBox::selectionState accessor mutates ellipsis selection state
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
Keywords: InRadar
Depends on: 205318
  Show dependency treegraph
Reported: 2019-12-20 16:22 PST by Megan Gardner
Modified: 2021-09-13 10:49 PDT (History)
10 users (show)

See Also:

Patch (10.23 KB, patch)
2021-09-13 03:51 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-12-20 16:22:42 PST
The code that deals with ellipsis and selections is in a place that sounds like it should not be mutating state, but it is. This should likely move to SelectionRangeData. Move this code, and also make sure that it also works with the new HighlightAPI.
Comment 1 Megan Gardner 2019-12-20 16:23:30 PST
Comment 2 Antti Koivisto 2021-09-13 03:51:37 PDT
Created attachment 438026 [details]
Comment 3 EWS 2021-09-13 10:48:03 PDT
Committed r282337 (241604@main): <https://commits.webkit.org/241604@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438026 [details].
Comment 4 Radar WebKit Bug Importer 2021-09-13 10:49:24 PDT