Bug 20552 - CSSRule.idl missing keyframe-related RuleTypes
Summary: CSSRule.idl missing keyframe-related RuleTypes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-27 17:16 PDT by Simon Fraser (smfr)
Modified: 2008-08-28 14:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch, testcase, changelog (3.07 KB, patch)
2008-08-27 17:39 PDT, Simon Fraser (smfr)
eric: review+
Details | Formatted Diff | Diff
Fixed fast/dom/Window/window-properties-expected.txt (3.98 KB, text/plain)
2008-08-28 14:39 PDT, Simon Fraser (smfr)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2008-08-27 17:16:33 PDT
CSSRule.idl is missing the keyframe-related rule types:

        const unsigned short WEBKIT_KEYFRAMES_RULE = 8;
        const unsigned short WEBKIT_KEYFRAME_RULE = 9;
Comment 1 Simon Fraser (smfr) 2008-08-27 17:39:03 PDT
Created attachment 23046 [details]
Patch, testcase, changelog
Comment 2 Eric Seidel (no email) 2008-08-27 17:42:36 PDT
Comment on attachment 23046 [details]
Patch, testcase, changelog

This really should be using the newer js-style tests, which have "shouldBe" functions provided for you to produce nice "PASS" "FAIL" output for subtests like this.  I would encourage you to look at the tests in fast/js or ask ggaren for more infos.   make-js-test-wrappers is part of that whole system and turns the .js files + resources/TEMPLATE.html into the resuling browser-runnable test files.

Change looks fine though.
Comment 3 Simon Fraser (smfr) 2008-08-28 10:30:31 PDT
Committed, with make-js-test-wrapper based test:

Committed r35972
	M	WebCore/ChangeLog
	M	WebCore/css/CSSRule.idl
	M	LayoutTests/ChangeLog
	A	LayoutTests/animations/animation-css-rule-types.html
	A	LayoutTests/animations/animation-css-rule-types-expected.txt
	A	LayoutTests/animations/resources/animation-css-rule-types.js
	A	LayoutTests/animations/resources/TEMPLATE.html
r35972 = ae77c41c078d3a1cf4ecfe7f174226da32f87712 (trunk)
Comment 4 Simon Fraser (smfr) 2008-08-28 14:18:52 PDT
This change broke fast/dom/Window/window-properties.html, which I shall fix.
Comment 5 Simon Fraser (smfr) 2008-08-28 14:39:14 PDT
Created attachment 23060 [details]
Fixed fast/dom/Window/window-properties-expected.txt
Comment 6 Simon Fraser (smfr) 2008-08-28 14:41:17 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/dom/Window/window-properties-expected.txt
Committed r35980