Bug 205513 - lldbwebkittester: Strip CLANG_DEBUG_INFORMATION_LEVEL option while building
Summary: lldbwebkittester: Strip CLANG_DEBUG_INFORMATION_LEVEL option while building
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-20 11:56 PST by Jonathan Bedard
Modified: 2019-12-20 14:31 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2019-12-20 12:58 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.51 KB, patch)
2019-12-20 13:46 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-12-20 11:56:15 PST 
When built with CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only, our lldb tests don't work. We should disable these tests on release queues.
Comment 1 Jonathan Bedard 2019-12-20 12:37:25 PST 
Talking with Alexey, we're going to the opposite: we're going to fix release binaries so they can run lldb tests instead.
Comment 2 Jonathan Bedard 2019-12-20 12:58:46 PST 
Created attachment 386242 [details]
Patch
Comment 3 Alexey Proskuryakov 2019-12-20 13:37:13 PST 
Comment on attachment 386242 [details]
Patch

Worth explaining this in a comment. 

We are lucky that fixing “make” builds is not necessary at the moment.
Comment 4 Jonathan Bedard 2019-12-20 13:46:52 PST 
Created attachment 386246 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-12-20 14:30:40 PST 
Comment on attachment 386246 [details]
Patch for landing

Clearing flags on attachment: 386246

Committed r253845: <https://trac.webkit.org/changeset/253845>
Comment 6 WebKit Commit Bot 2019-12-20 14:30:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-20 14:31:30 PST 
<rdar://problem/58125695>