Bug 205511 - [Media in GPU process] Get audio playing
Summary: [Media in GPU process] Get audio playing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks: 205123
  Show dependency tree / graph
 
Reported: 2019-12-20 11:18 PST by Eric Carlson
Modified: 2019-12-20 23:35 PST (History)
8 users (show)

See Also:

Attachments
Patch (53.98 KB, patch)
2019-12-20 14:23 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (55.21 KB, patch)
2019-12-20 14:42 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (51.61 KB, patch)
2019-12-20 15:19 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (55.94 KB, patch)
2019-12-20 15:28 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-12-20 11:18:00 PST 
Get audio playing in GPU process
Comment 1 Radar WebKit Bug Importer 2019-12-20 11:18:18 PST 
<rdar://problem/58120354>
Comment 2 Eric Carlson 2019-12-20 14:23:23 PST 
Created attachment 386254 [details]
Patch
Comment 3 Eric Carlson 2019-12-20 14:42:59 PST 
Created attachment 386260 [details]
Patch
Comment 4 Jer Noble 2019-12-20 14:51:17 PST 
Comment on attachment 386260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386260&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:888
> -#if HAVE(AVFOUNDATION_LOADER_DELEGATE)
> +#if HAVE(AVFOUNDATION_LOADER_DELEGATE) && 0

?
Comment 5 Eric Carlson 2019-12-20 15:19:50 PST 
Created attachment 386266 [details]
Patch for landing
Comment 6 Eric Carlson 2019-12-20 15:28:37 PST 
Created attachment 386269 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-12-20 23:35:52 PST 
Comment on attachment 386269 [details]
Patch for landing

Clearing flags on attachment: 386269

Committed r253861: <https://trac.webkit.org/changeset/253861>
Comment 8 WebKit Commit Bot 2019-12-20 23:35:54 PST 
All reviewed patches have been landed.  Closing bug.