Bug 205508 - IsolatedObject support for multiple parameterized attributes.
Summary: IsolatedObject support for multiple parameterized attributes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-20 10:39 PST by Andres Gonzalez
Modified: 2019-12-20 12:34 PST (History)
10 users (show)

See Also:

Attachments
Patch (36.01 KB, patch)
2019-12-20 10:51 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2019-12-20 10:39:42 PST 
IsolatedObject support for multiple parameterized attributes.
Comment 1 Andres Gonzalez 2019-12-20 10:51:51 PST 
Created attachment 386224 [details]
Patch
Comment 2 chris fleizach 2019-12-20 11:01:15 PST 
Comment on attachment 386224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386224&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp:1409
> +    return associatedAXObject()->documentFrameView();

do we want main thread asserts in these?
Comment 3 Andres Gonzalez 2019-12-20 11:16:19 PST 
(In reply to chris fleizach from comment #2)
> Comment on attachment 386224 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386224&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp:1409
> > +    return associatedAXObject()->documentFrameView();
> 
> do we want main thread asserts in these?

They already do because associatedAXObject calls axObjectCache() that asserts isMainThread.
Comment 4 WebKit Commit Bot 2019-12-20 12:33:27 PST 
Comment on attachment 386224 [details]
Patch

Clearing flags on attachment: 386224

Committed r253835: <https://trac.webkit.org/changeset/253835>
Comment 5 WebKit Commit Bot 2019-12-20 12:33:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-12-20 12:34:19 PST 
<rdar://problem/58122420>