RESOLVED FIXED 205507
Add a Custom User Agent menu to MiniBrowser, and related cleanup 
https://bugs.webkit.org/show_bug.cgi?id=205507
Summary Add a Custom User Agent menu to MiniBrowser, and related cleanup
Simon Fraser (smfr)
Reported 2019-12-20 09:47:34 PST
Add a Custom User Agent menu to MiniBrowser, and related cleanup
Attachments
Patch (36.70 KB, patch)
2019-12-20 09:51 PST, Simon Fraser (smfr) 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-12-20 09:51:34 PST
Created attachment 386220 [details] Patch
Wenson Hsieh
Comment 2 2019-12-20 10:00:09 PST
Comment on attachment 386220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386220&action=review > Tools/MiniBrowser/mac/AppDelegate.m:87 > +// [[NSApp mainMenu] insertItem:[item autorelease] atIndex:[[NSApp mainMenu] indexOfItemWithTitle:@"Debug"]]; Nit - I think you meant to remove this line? > Tools/MiniBrowser/mac/SettingsController.m:150 > + NSMenuItem *userAgentSubmenuItem = [[NSMenuItem alloc] initWithTitle:@"User Agent" action:nil keyEquivalent:@""]; > + NSMenu *userAgentMenu = [[NSMenu alloc] initWithTitle:@"User Agent"]; It seems like these two will leak. I wonder if we can just use RetainPtr instead here (though it looks like nothing else in MiniBrowser includes wtf headers :/)
Tim Horton
Comment 3 2019-12-20 11:15:33 PST
We should ARC minibrowser :P
Simon Fraser (smfr)
Comment 4 2019-12-20 13:47:32 PST
https://trac.webkit.org/changeset/253840/webkit
Radar WebKit Bug Importer
Comment 5 2019-12-20 13:48:31 PST
<rdar://problem/58124430>
Note You need to log in before you can comment on or make changes to this bug.