Import web-platform-tests/subresource-integrity tests from usptream.
Created attachment 386217 [details] Patch
Comment on attachment 386217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386217&action=review > LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-css-ed25519.tentative-expected.txt:3 > +FAIL Style: Fails, because the key is malformed. assert_unreached: Bad load succeeded. Reached unreachable code Interestingly, we seem to have some test failures. > LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519-with-csp.tentative-expected.txt:2 > +FAIL Script: Ed25519-with-CSP, passes, valid key, valid signature. assert_unreached: Good load fired error handler. Reached unreachable code and here > LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519.tentative-expected.txt:3 > +FAIL Script: Ed255519 signature, fails because key is malformed. assert_unreached: Bad load succeeded. Reached unreachable code And here.
Comment on attachment 386217 [details] Patch Rejecting attachment 386217 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 386217, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: ntegrity/crossorigin-anon-style.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/crossorigin-creds-style.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/crossorigin-creds-style.css.sub.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/crossorigin-ineligible-style.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-broken-signature.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-broken-signature.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature-headers.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature-headers.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature2.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature2.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-no-signature.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-signature.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-signature.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-signature2.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-signature2.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature-headers.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature-headers.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature2.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature2.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-no-signature.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-wrong-signature.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-wrong-signature.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/script.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/sri-test-helpers.sub.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/style.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-css-ed25519.tentative-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-css-ed25519.tentative.html patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519-with-csp.tentative-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519-with-csp.tentative.html patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519.tentative-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519.tentative.html patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-integrity-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-integrity.html patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/tools/ed25519.py patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/tools/generate_javascript.py patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/tools/list_hashes.py patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/tools/w3c-import.log patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/w3c-import.log Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13293959
Comment on attachment 386217 [details] Patch Rejecting attachment 386217 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 386217, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: ntegrity/crossorigin-anon-style.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/crossorigin-creds-style.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/crossorigin-creds-style.css.sub.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/crossorigin-ineligible-style.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-broken-signature.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-broken-signature.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature-headers.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature-headers.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature2.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-multi-signature2.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-no-signature.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-signature.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-signature.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-signature2.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-signature2.js.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature-headers.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature-headers.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature2.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-multi-signature2.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-no-signature.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-wrong-signature.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style-wrong-signature.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/ed25519-style.css.headers patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/script.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/sri-test-helpers.sub.js patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/style.css patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-css-ed25519.tentative-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-css-ed25519.tentative.html patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519-with-csp.tentative-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519-with-csp.tentative.html patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519.tentative-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519.tentative.html patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-integrity-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-integrity.html patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/tools/ed25519.py patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/tools/generate_javascript.py patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/tools/list_hashes.py patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/tools/w3c-import.log patching file LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/w3c-import.log Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13293965
Created attachment 386223 [details] Patch
Comment on attachment 386223 [details] Patch Clearing flags on attachment: 386223 Committed r253829: <https://trac.webkit.org/changeset/253829>
All reviewed patches have been landed. Closing bug.
<rdar://problem/58119881>
Reverted r253829 for reason: This is blocking the rollout of r253705 Committed r253831: <https://trac.webkit.org/changeset/253831>
Reverted r253831 for reason: Inadvertent rollout of r253829 Committed r253832: <https://trac.webkit.org/changeset/253832>
(In reply to Chris Dumez from comment #2) > Comment on attachment 386217 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386217&action=review > > > LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-css-ed25519.tentative-expected.txt:3 > > +FAIL Style: Fails, because the key is malformed. assert_unreached: Bad load succeeded. Reached unreachable code > > Interestingly, we seem to have some test failures. > > > LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519-with-csp.tentative-expected.txt:2 > > +FAIL Script: Ed25519-with-CSP, passes, valid key, valid signature. assert_unreached: Good load fired error handler. Reached unreachable code > > and here > > > LayoutTests/imported/w3c/web-platform-tests/subresource-integrity/subresource-ed25519.tentative-expected.txt:3 > > +FAIL Script: Ed255519 signature, fails because key is malformed. assert_unreached: Bad load succeeded. Reached unreachable code > > And here. It could be an issue with the test, Firefox and Chrome appear to be failing the same checks as us.