Bug 205497 - [GTK] InputMethod API unit tests don't work under X11
Summary: [GTK] InputMethod API unit tests don't work under X11
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2019-12-20 05:29 PST by Carlos Garcia Campos
Modified: 2019-12-23 02:06 PST (History)
5 users (show)

See Also:

Patch (8.42 KB, patch)
2019-12-20 05:32 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (8.44 KB, patch)
2019-12-20 05:56 PST, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-12-20 05:29:21 PST
The input method filter requires the web view to be focused to be enabled. Under X11 we only get the focus if the parent window is a toplevel and tests were using a popup. Using a toplevelo is enough for X11 with a window manager, but not for tests running under xvfb because there isn't a window manager. We need to assume the web view is always focused when running the tests under xvfb
Comment 1 Carlos Garcia Campos 2019-12-20 05:32:54 PST
Created attachment 386209 [details]
Comment 2 EWS Watchlist 2019-12-20 05:33:45 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2019-12-20 05:56:01 PST
Created attachment 386210 [details]
Comment 4 Carlos Garcia Campos 2019-12-23 02:06:37 PST
Committed r253882: <https://trac.webkit.org/changeset/253882>