205496 – Deny Notification API access for non secure contexts

Bug 205496 - Deny Notification API access for non secure contexts

Summary: Deny Notification API access for non secure contexts

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebCore Misc. (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	youenn fablet

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2019-12-20 05:17 PST by youenn fablet
Modified:	2019-12-24 06:41 PST (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (1.53 KB, patch) 2019-12-20 05:28 PST, youenn fablet	no flags	Details \| Formatted Diff \| Diff
Patch (4.39 KB, patch) 2019-12-20 09:54 PST, youenn fablet	no flags	Details \| Formatted Diff \| Diff
Fix API test (6.23 KB, patch) 2019-12-24 03:35 PST, youenn fablet	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description youenn fablet 2019-12-20 05:17:12 PST

Make Notification API SecureContext

Comment 1 youenn fablet 2019-12-20 05:18:13 PST

Spec issue link: https://github.com/whatwg/notifications/issues/93
Chrome intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/n37ij1E_1aY
Firefox intent to ship: https://groups.google.com/forum/#!topic/mozilla.dev.platform/FMPrIMGBNtg

Comment 2 youenn fablet 2019-12-20 05:18:25 PST

<rdar://problem/58074660>

Comment 3 youenn fablet 2019-12-20 05:28:42 PST

Created attachment 386208 [details]
Patch

Comment 4 Chris Dumez 2019-12-20 08:03:27 PST

Comment on attachment 386208 [details]
Patch

Layout test please. See internals.markContextAsInsecure().

Comment 5 Chris Dumez 2019-12-20 08:11:21 PST

Comment on attachment 386208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386208&action=review

> Source/WebCore/ChangeLog:8
> +

Also, please beef up the change log to include some of the information that is on the radar. In particular, the spec issue about this (since the new behavior does not currently match the spec) and the behavior of other browsers.

Comment 6 youenn fablet 2019-12-20 09:54:18 PST

Created attachment 386221 [details]
Patch

Comment 7 youenn fablet 2019-12-20 10:01:05 PST

Thanks for the review. I don’t have a compiler right now so I haven’t validated the patch. I’ll fix the patch if ews is not happy.

Comment 8 youenn fablet 2019-12-24 03:35:16 PST

Created attachment 386387 [details]
Fix API test

Comment 9 WebKit Commit Bot 2019-12-24 06:41:27 PST

Comment on attachment 386387 [details]
Fix API test

Clearing flags on attachment: 386387

Committed r253899: <https://trac.webkit.org/changeset/253899>

Comment 10 WebKit Commit Bot 2019-12-24 06:41:29 PST

All reviewed patches have been landed.  Closing bug.