Bug 205491 - Compile libwebrtc without hardware acceleration for iOS simulator
Summary: Compile libwebrtc without hardware acceleration for iOS simulator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-20 00:50 PST by youenn fablet
Modified: 2019-12-23 05:26 PST (History)
9 users (show)

See Also:

Attachments
Patch (701.11 KB, patch)
2019-12-20 01:11 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-20 00:50:59 PST 
Compile libwebrtc without hardware acceleration for iOS simulator
Comment 1 youenn fablet 2019-12-20 01:11:44 PST 
Created attachment 386187 [details]
Patch
Comment 2 youenn fablet 2019-12-20 04:47:50 PST 
This patch does not remove yasm as a dependency to libvpx in iOS and iOS simulator.
I think we should do that as a follow-up.
Comment 3 Keith Rollin 2019-12-20 11:25:41 PST 
You're adding a number of files here that are marked as "// This file is generated. Do not edit." Should these files be checked in? Or should we just include their generation as part of the build process? Personally, I prefer the latter. But if the former, are there instructions how to (re-)generate them later if needed?
Comment 4 Keith Rollin 2019-12-20 11:28:01 PST 
Also, these new files are presumably for the iOS-simulator build. But the files are stored in a mac/x86 directory. Wouldn't we already have such files for the macOS build? Why are there new files?
Comment 5 Alex Christensen 2019-12-20 11:29:46 PST 
The macOS build uses yasm to get optimized x86_64 vpx code.  That's not needed in the iOS simulator.  We could put them in iOS/x86 instead of Mac/x86
Comment 6 Keith Rollin 2019-12-20 11:30:18 PST 
Sorry. I got a little confused there. I was thinking that the C/C++ files should already exist for *iOS* (not macOS), right? Can't those be used for the iOS Simulator build?
Comment 7 Keith Rollin 2019-12-20 15:04:46 PST 
With this change, you can also get rid of the DYLD_ROOT_PATH hack in the custom build rule that invokes yasm.
Comment 8 youenn fablet 2019-12-22 05:55:59 PST 
(In reply to Keith Rollin from comment #6)
> Sorry. I got a little confused there. I was thinking that the C/C++ files
> should already exist for *iOS* (not macOS), right? Can't those be used for
> the iOS Simulator build?

The files for iOS expect arm and iOS sim is x86_64 based which makes it somehow closer to macOS for the build.
I guess we could use iOS files and tweak them for iOS sim as well.
Comment 9 youenn fablet 2019-12-22 05:56:25 PST 
(In reply to Keith Rollin from comment #7)
> With this change, you can also get rid of the DYLD_ROOT_PATH hack in the
> custom build rule that invokes yasm.

Will do in a follow-up, with the removal of yasm as a dependency to libvpx for iOS/iOS sim
Comment 10 WebKit Commit Bot 2019-12-22 06:42:57 PST 
Comment on attachment 386187 [details]
Patch

Clearing flags on attachment: 386187

Committed r253872: <https://trac.webkit.org/changeset/253872>
Comment 11 WebKit Commit Bot 2019-12-22 06:42:59 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-12-22 06:43:15 PST 
<rdar://problem/58142578>
Comment 13 youenn fablet 2019-12-23 05:26:59 PST 
(In reply to youenn fablet from comment #9)
> (In reply to Keith Rollin from comment #7)
> > With this change, you can also get rid of the DYLD_ROOT_PATH hack in the
> > custom build rule that invokes yasm.
> 
> Will do in a follow-up, with the removal of yasm as a dependency to libvpx
> for iOS/iOS sim

https://bugs.webkit.org/show_bug.cgi?id=205556