Bug 205491 – Compile libwebrtc without hardware acceleration for iOS simulator

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Compile libwebrtc without hardware acceleration for iOS simulator

[youenn fablet]

Created attachment 386187 [details]
Patch

[youenn fablet]

This patch does not remove yasm as a dependency to libvpx in iOS and iOS simulator.
I think we should do that as a follow-up.

[Keith Rollin]

You're adding a number of files here that are marked as "// This file is generated. Do not edit." Should these files be checked in? Or should we just include their generation as part of the build process? Personally, I prefer the latter. But if the former, are there instructions how to (re-)generate them later if needed?

[Keith Rollin]

Also, these new files are presumably for the iOS-simulator build. But the files are stored in a mac/x86 directory. Wouldn't we already have such files for the macOS build? Why are there new files?

[Alex Christensen]

The macOS build uses yasm to get optimized x86_64 vpx code.  That's not needed in the iOS simulator.  We could put them in iOS/x86 instead of Mac/x86

[Keith Rollin]

Sorry. I got a little confused there. I was thinking that the C/C++ files should already exist for *iOS* (not macOS), right? Can't those be used for the iOS Simulator build?

[Keith Rollin]

With this change, you can also get rid of the DYLD_ROOT_PATH hack in the custom build rule that invokes yasm.

[youenn fablet]

(In reply to Keith Rollin from comment #6)
> Sorry. I got a little confused there. I was thinking that the C/C++ files
> should already exist for *iOS* (not macOS), right? Can't those be used for
> the iOS Simulator build?

The files for iOS expect arm and iOS sim is x86_64 based which makes it somehow closer to macOS for the build.
I guess we could use iOS files and tweak them for iOS sim as well.

[youenn fablet]

(In reply to Keith Rollin from comment #7)
> With this change, you can also get rid of the DYLD_ROOT_PATH hack in the
> custom build rule that invokes yasm.

Will do in a follow-up, with the removal of yasm as a dependency to libvpx for iOS/iOS sim

[WebKit Commit Bot]

Comment on attachment 386187 [details]
Patch

Clearing flags on attachment: 386187

Committed r253872: <https://trac.webkit.org/changeset/253872>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58142578>

[youenn fablet]

(In reply to youenn fablet from comment #9)
> (In reply to Keith Rollin from comment #7)
> > With this change, you can also get rid of the DYLD_ROOT_PATH hack in the
> > custom build rule that invokes yasm.
> 
> Will do in a follow-up, with the removal of yasm as a dependency to libvpx
> for iOS/iOS sim

https://bugs.webkit.org/show_bug.cgi?id=205556