Bug 205475 - Web Inspector: convert some InspectorFrontendHost methods to getters
Summary: Web Inspector: convert some InspectorFrontendHost methods to getters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-19 14:36 PST by BJ Burg
Modified: 2019-12-20 12:46 PST (History)
6 users (show)

See Also:

Attachments
Patch (13.13 KB, patch)
2019-12-19 14:38 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Proposed fix (22.35 KB, patch)
2019-12-19 14:59 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch (24.14 KB, patch)
2019-12-19 16:04 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch (26.59 KB, patch)
2019-12-20 11:07 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2019-12-19 14:36:22 PST 
.
Comment 1 BJ Burg 2019-12-19 14:38:21 PST 
Created attachment 386143 [details]
Patch
Comment 2 BJ Burg 2019-12-19 14:59:43 PST 
Created attachment 386150 [details]
Proposed fix
Comment 3 BJ Burg 2019-12-19 16:04:04 PST 
Created attachment 386161 [details]
Patch
Comment 4 Devin Rousso 2019-12-19 16:09:24 PST 
Comment on attachment 386161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386161&action=review

r=me once EWS is happy :)

> Source/WebCore/inspector/InspectorFrontendHost.h:85
>      String port();

Shouldn't this also be `const`?

> Source/WebCore/inspector/InspectorFrontendHost.h:89
> +    String platform() const;

NIT: why not put this next to `port`?
Comment 5 BJ Burg 2019-12-20 11:07:24 PST 
Created attachment 386226 [details]
Patch
Comment 6 BJ Burg 2019-12-20 12:42:58 PST 
Committed r253837: <https://trac.webkit.org/changeset/253837>
Comment 7 Radar WebKit Bug Importer 2019-12-20 12:43:18 PST 
<rdar://problem/58122650>