Bug 205443 – [iOS] Issue mach sandbox extension to the frontboard and icon service when the attachment element is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

When support for the html attachment element is enabled, issue a mach lookup extension to the frontboard service for the WebContent process, since this daemon is being contacted when icons for attachments are being queried.

[Per Arne Vollan]

Created attachment 386090 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/58074291>

[Per Arne Vollan]

Created attachment 386099 [details]
Patch

[Brent Fulgham]

Comment on attachment 386099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386099&action=review

r=me

> Source/WebKit/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=205443

Please add the radar

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:345
> +        SandboxExtension::createHandleForMachLookup("com.apple.frontboard.systemappservices", WTF::nullopt, handle);

Do we have a similar situation on macOS (using a different mach-port)? We should file a radar to investigate and address that, too.

[Per Arne Vollan]

Created attachment 387940 [details]
Patch

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 386099 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386099&action=review
> 
> r=me
> 
> > Source/WebKit/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=205443
> 
> Please add the radar
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:345
> > +        SandboxExtension::createHandleForMachLookup("com.apple.frontboard.systemappservices", WTF::nullopt, handle);
> 
> Do we have a similar situation on macOS (using a different mach-port)? We
> should file a radar to investigate and address that, too.

I don't know which port this would be on macOS, but I think it is likely there is a counterpart. I will file a radar.

I uploaded another patch with an additional fix for getting the focus ring color in the UI process.

Thanks for reviewing!

[Brent Fulgham]

Comment on attachment 387940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387940&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.cpp:7614
> +        SandboxExtension::createHandleForMachLookup("com.apple.iconservices", WTF::nullopt, handle);

Should we handle icon services under a different radar? We probably need this on macOS, too, so it would be nice to do both together?

[Brent Fulgham]

(In reply to Brent Fulgham from comment #7)
> Comment on attachment 387940 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387940&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:7614
> > +        SandboxExtension::createHandleForMachLookup("com.apple.iconservices", WTF::nullopt, handle);
> 
> Should we handle icon services under a different radar? We probably need
> this on macOS, too, so it would be nice to do both together?

I spoke with Per Arne offline. We should proceed with this patch as-is, and do a similar patch on macOS after validating if any other changes are needed there.

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #8)
> (In reply to Brent Fulgham from comment #7)
> > Comment on attachment 387940 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=387940&action=review
> > 
> > r=me
> > 
> > > Source/WebKit/UIProcess/WebPageProxy.cpp:7614
> > > +        SandboxExtension::createHandleForMachLookup("com.apple.iconservices", WTF::nullopt, handle);
> > 
> > Should we handle icon services under a different radar? We probably need
> > this on macOS, too, so it would be nice to do both together?
> 
> I spoke with Per Arne offline. We should proceed with this patch as-is, and
> do a similar patch on macOS after validating if any other changes are needed
> there.

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 387940 [details]
Patch

Rejecting attachment 387940 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 387940, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=387940&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=205443&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 387940 from bug 205443.
Fetching: https://bugs.webkit.org/attachment.cgi?id=387940
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 23 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderTheme.h
patching file Source/WebCore/rendering/RenderThemeIOS.h
patching file Source/WebCore/rendering/RenderThemeIOS.mm
patching file Source/WebCore/testing/Internals.cpp
Hunk #1 succeeded at 5455 with fuzz 1 (offset 20 lines).
patching file Source/WebCore/testing/Internals.h
Hunk #1 succeeded at 933 with fuzz 2 (offset 7 lines).
patching file Source/WebCore/testing/Internals.idl
Hunk #1 FAILED at 833.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/testing/Internals.idl.rej
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
Hunk #1 FAILED at 955.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.rej
patching file Source/WebKit/Shared/WebPageCreationParameters.cpp
Hunk #1 succeeded at 92 with fuzz 2 (offset -7 lines).
Hunk #2 succeeded at 301 with fuzz 1 (offset -9 lines).
patching file Source/WebKit/Shared/WebPageCreationParameters.h
Hunk #1 succeeded at 152 with fuzz 2 (offset -8 lines).
patching file Source/WebKit/Shared/WebProcessCreationParameters.cpp
Hunk #1 succeeded at 173 (offset 2 lines).
Hunk #2 succeeded at 459 (offset 14 lines).
patching file Source/WebKit/Shared/WebProcessCreationParameters.h
Hunk #1 succeeded at 215 (offset 2 lines).
patching file Source/WebKit/UIProcess/WebPageProxy.cpp
Hunk #1 succeeded at 7651 with fuzz 2 (offset 45 lines).
patching file Source/WebKit/UIProcess/WebProcessProxy.h
Hunk #1 succeeded at 354 (offset 7 lines).
Hunk #2 succeeded at 537 (offset 10 lines).
patching file Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
Hunk #1 succeeded at 360 (offset 6 lines).
patching file Source/WebKit/WebProcess/WebPage/WebPage.cpp
Hunk #1 succeeded at 526 (offset 2 lines).
patching file Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Hunk #1 succeeded at 267 (offset 5 lines).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/sandbox/ios/focus-ring-color-expected.txt
patching file LayoutTests/fast/sandbox/ios/focus-ring-color.html
patching file LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-attachment-element-expected.txt
patching file LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-attachment-element.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13314023

[Per Arne Vollan]

Created attachment 389265 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 389265 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 389265 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 389265 [details]
Patch

Clearing flags on attachment: 389265

Committed r255457: <https://trac.webkit.org/changeset/255457>