Bug 205438 – Web Inspector: Console: the clear console button is hidden at smaller widths

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Ever since r242604, we no longer "need" to show the text filter bar or message type scope bar since new messages will show a warning banner that there's an active filter.  Instead, we should prefer showing the navigation items that control functionality that cannot be reached (visually) anywhere else, such as clearing the console or evaluating as a user gesture.

[Devin Rousso]

Created attachment 386074 [details]
Patch

[Blaze Burg]

Comment on attachment 386074 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 386074 [details]
Patch

Rejecting attachment 386074 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 386074, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=386074&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=205438&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 386074 from bug 205438.
Fetching: https://bugs.webkit.org/attachment.cgi?id=386074
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebInspectorUI/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date
W: 277f3cd7e10c1507d743533d24e29fe44dd5399c and refs/remotes/origin/master differ, using rebase:
:040000 040000 1236d47d9f6b2151c90cede622a58ba66deaf71b a9826ad16b45839d3a15accb7f58c156b14aed9d M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebInspectorUI/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date
W: 277f3cd7e10c1507d743533d24e29fe44dd5399c and refs/remotes/origin/master differ, using rebase:
:040000 040000 1236d47d9f6b2151c90cede622a58ba66deaf71b a9826ad16b45839d3a15accb7f58c156b14aed9d M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   7f55b0e8419..02850c19cb3  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 253754 = 7f55b0e8419b0f7f848024e2eda6c3e03f79004f
r253755 = 28e53b982780dd170d821b2370d77e870f6a4d4f
r253756 = 02850c19cb3d0fe9b02985390489b2c5f6b1187e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13293402

[Devin Rousso]

Created attachment 386151 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 386151 [details]
Patch

Clearing flags on attachment: 386151

Committed r253800: <https://trac.webkit.org/changeset/253800>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58096134>