Bug 205429 - macCatalyst: Cursor should update when the platform deems it necessary
Summary: macCatalyst: Cursor should update when the platform deems it necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-18 17:54 PST by Tim Horton
Modified: 2019-12-18 18:21 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.87 KB, patch)
2019-12-18 17:55 PST, Tim Horton 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-12-18 17:54:37 PST 
macCatalyst: Cursor should update when the platform deems it necessary
Comment 1 Tim Horton 2019-12-18 17:55:13 PST 
Created attachment 386044 [details]
Patch
Comment 2 Tim Horton 2019-12-18 17:55:15 PST 
<rdar://problem/57983076>
Comment 3 Wenson Hsieh 2019-12-18 17:57:13 PST 
Comment on attachment 386044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386044&action=review

> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:87
> +    float caretHeight;

Nit - maybe give this an initial value?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2766
> +    if (Frame* frame = hitTestResult.innerNodeFrame()) {
> +        if (FrameView *frameView = frame->view()) {

Nit - auto*?
Comment 4 Tim Horton 2019-12-18 18:21:53 PST 
https://trac.webkit.org/changeset/253731/webkit