WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
205429
macCatalyst: Cursor should update when the platform deems it necessary
https://bugs.webkit.org/show_bug.cgi?id=205429
Summary
macCatalyst: Cursor should update when the platform deems it necessary
Tim Horton
Reported
2019-12-18 17:54:37 PST
macCatalyst: Cursor should update when the platform deems it necessary
Attachments
Patch
(5.87 KB, patch)
2019-12-18 17:55 PST
,
Tim Horton
wenson_hsieh
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2019-12-18 17:55:13 PST
Created
attachment 386044
[details]
Patch
Tim Horton
Comment 2
2019-12-18 17:55:15 PST
<
rdar://problem/57983076
>
Wenson Hsieh
Comment 3
2019-12-18 17:57:13 PST
Comment on
attachment 386044
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=386044&action=review
> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:87 > + float caretHeight;
Nit - maybe give this an initial value?
> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2766 > + if (Frame* frame = hitTestResult.innerNodeFrame()) { > + if (FrameView *frameView = frame->view()) {
Nit - auto*?
Tim Horton
Comment 4
2019-12-18 18:21:53 PST
https://trac.webkit.org/changeset/253731/webkit
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug