Bug 205413 – IndexedDB: delete index records with ID and IndexKey instead of value in SQLiteIDBackingStore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sihui Liu]

...

[Sihui Liu]

Created attachment 386020 [details]
Patch

[Geoffrey Garen]

Comment on attachment 386020 [details]
Patch

r=me

It sounds like we can do even better if we delete by key -- but this patch is an improvement too.

[Sihui Liu]

Created attachment 386153 [details]
Patch

[Alex Christensen]

Comment on attachment 386153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386153&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1546
> +        sql->getColumnBlobAsVector(1, valueBuffer);

Could you make getColumnBlobAsVector return a Vector<uint8_t> and make a getColumnBlobAsCharVector that returns a Vector<char>?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1601
> +                indexKeys.append(indexKey.asOneKey());

Could you write this so that if there's one key, we don't need to allocate a Vector?  That would probably just move the isValid() check into deleteOneIndexRecord

[Sihui Liu]

Comment on attachment 386153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386153&action=review

>> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1546
>> +        sql->getColumnBlobAsVector(1, valueBuffer);
> 
> Could you make getColumnBlobAsVector return a Vector<uint8_t> and make a getColumnBlobAsCharVector that returns a Vector<char>?

Yes. I could make that change but prefer doing it in a different bug as it's not relevant to what the patch is for.

>> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1601
>> +                indexKeys.append(indexKey.asOneKey());
> 
> Could you write this so that if there's one key, we don't need to allocate a Vector?  That would probably just move the isValid() check into deleteOneIndexRecord

Sure.

[Sihui Liu]

Created attachment 386261 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 386261 [details]
Patch

Clearing flags on attachment: 386261

Committed r254030: <https://trac.webkit.org/changeset/254030>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58314409>