Bug 205404 - [LFC][IFC] LineLayoutContext::m_uncommittedList is not always a continuous list of runs
Summary: [LFC][IFC] LineLayoutContext::m_uncommittedList is not always a continuous li...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-18 11:04 PST by zalan
Modified: 2019-12-30 11:11 PST (History)
6 users (show)

See Also:

Attachments
Patch (16.78 KB, patch)
2019-12-18 11:24 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (16.77 KB, patch)
2019-12-18 12:44 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-12-18 11:04:56 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2019-12-18 11:05:40 PST 
<rdar://problem/58049699>
Comment 2 zalan 2019-12-18 11:24:28 PST 
Created attachment 385988 [details]
Patch
Comment 3 Antti Koivisto 2019-12-18 11:27:34 PST 
Comment on attachment 385988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385988&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.h:72
> +        void shrink(unsigned newSize);

Can we use size_t everywhere?
Comment 4 zalan 2019-12-18 12:44:10 PST 
Created attachment 385995 [details]
Patch
Comment 5 WebKit Commit Bot 2019-12-18 13:29:03 PST 
Comment on attachment 385995 [details]
Patch

Clearing flags on attachment: 385995

Committed r253711: <https://trac.webkit.org/changeset/253711>
Comment 6 WebKit Commit Bot 2019-12-18 13:29:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 zalan 2019-12-19 11:20:35 PST 
Reverted r253711 for reason:

Broke two tests on Mac and iOS

Committed r253770: <https://trac.webkit.org/changeset/253770>