Bug 205382 – [GStreamer][EME] Notify all elements waiting for CDM attachment

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Charlie Turner]

[GStreamer][EME] Notify all elements waiting for CDM attachment

[Charlie Turner]

Created attachment 385978 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 385978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385978&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1794
> +        auto cdmAttachmentLocker = holdLock(m_cdmAttachmentMutex);
> +        bool didCDMAttach = m_cdmAttachmentCondition.waitFor(m_cdmAttachmentMutex, 4_s, [this]() {
> +            return isCDMAttached();
> +        });
> +        cdmAttachmentLocker.unlockEarly();

I would prefer to take the boolean definition outside and open a nested scope to avoid unlocking early. I think it is less future error prone.

> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:768
> +        else
> +            result = MediaPlayer::SupportsType::IsNotSupported;

As a personal preference I would move this upfront and avoid the else.

Anyway, this seems to be quite unrelated and I would recommend to land it in a another no-brainer bug.

[Charlie Turner]

Created attachment 386094 [details]
Patch

[Charlie Turner]

Created attachment 386095 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 386095 [details]
Patch

Rejecting attachment 386095 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 386095, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13293302

[Charlie Turner]

Created attachment 386096 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 386096 [details]
Patch

Clearing flags on attachment: 386096

Committed r253748: <https://trac.webkit.org/changeset/253748>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.