Bug 205375 - [WebAuthn] Merge some of the CTAP response decoder's code
Summary: [WebAuthn] Merge some of the CTAP response decoder's code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2019-12-17 21:18 PST by Jiewen Tan
Modified: 2020-02-10 12:27 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.78 KB, patch)
2020-02-07 15:17 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-12-17 21:18:46 PST 
Consider merging some of the CTAP request/response encoder/decoder's code.
Comment 1 Jiewen Tan 2020-02-07 15:17:41 PST 
Created attachment 390134 [details]
Patch
Comment 2 Jiewen Tan 2020-02-10 11:03:30 PST 
Comment on attachment 390134 [details]
Patch

Thanks for r+ this patch, Darin.
Comment 3 WebKit Commit Bot 2020-02-10 12:07:20 PST 
The commit-queue encountered the following flaky tests while processing attachment 390134 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-02-10 12:07:34 PST 
The commit-queue encountered the following flaky tests while processing attachment 390134 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-02-10 12:26:09 PST 
Comment on attachment 390134 [details]
Patch

Clearing flags on attachment: 390134

Committed r256201: <https://trac.webkit.org/changeset/256201>
Comment 6 WebKit Commit Bot 2020-02-10 12:26:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-10 12:27:18 PST 
<rdar://problem/59321089>