Bug 205371 - [LFC][IFC] LineBreaker::isAtSoftWrapOpportunity should return the wrap position
Summary: [LFC][IFC] LineBreaker::isAtSoftWrapOpportunity should return the wrap position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-17 18:57 PST by zalan
Modified: 2019-12-18 07:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.66 KB, patch)
2019-12-17 19:14 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-12-17 18:57:31 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2019-12-17 18:57:56 PST 
<rdar://problem/58029811>
Comment 2 zalan 2019-12-17 19:14:40 PST 
Created attachment 385934 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-12-17 19:16:50 PST 
Comment on attachment 385934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385934&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:293
> +        return { };

Is this 0 or WTF::nullopt?
Comment 4 zalan 2019-12-17 19:18:06 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 385934 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385934&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:293
> > +        return { };
> 
> Is this 0 or WTF::nullopt?
it's constructing an Optional<unsigned> object so I'd guess it's WTF::nullopt.
Comment 5 zalan 2019-12-18 07:39:55 PST 
Committed r253682: <https://trac.webkit.org/changeset/253682>