RESOLVED FIXED 205371
[LFC][IFC] LineBreaker::isAtSoftWrapOpportunity should return the wrap position 
https://bugs.webkit.org/show_bug.cgi?id=205371
Summary [LFC][IFC] LineBreaker::isAtSoftWrapOpportunity should return the wrap position
zalan
Reported 2019-12-17 18:57:31 PST
ssia
Attachments
Patch (9.66 KB, patch)
2019-12-17 19:14 PST, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-17 18:57:56 PST
<rdar://problem/58029811>
zalan
Comment 2 2019-12-17 19:14:40 PST
Created attachment 385934 [details] Patch
Simon Fraser (smfr)
Comment 3 2019-12-17 19:16:50 PST
Comment on attachment 385934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385934&action=review > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:293 > + return { }; Is this 0 or WTF::nullopt?
zalan
Comment 4 2019-12-17 19:18:06 PST
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 385934 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385934&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:293 > > + return { }; > > Is this 0 or WTF::nullopt? it's constructing an Optional<unsigned> object so I'd guess it's WTF::nullopt.
zalan
Comment 5 2019-12-18 07:39:55 PST
Committed r253682: <https://trac.webkit.org/changeset/253682>
Note You need to log in before you can comment on or make changes to this bug.