Bug 205362 – [LFC][IFC] Add lastInlineItemWithContent to LineBreaker::Content::isAtSoftWrapOpportunity

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

This is in preparation for LineBreaker::Content::isAtSoftWrapOpportunity being able to return a previous run index as soft wrap opportunity.

[Radar WebKit Bug Importer]

<rdar://problem/58025349>

[zalan]

Created attachment 385927 [details]
Patch

[Antti Koivisto]

Comment on attachment 385927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385927&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:299
> +        for (auto i = priorContent.size(); i--;) {
> +            auto& previousInlineItem = runs[i].inlineItem;

This could uses range for and WTF::makeReversedRange

> Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:304
> +            ASSERT_NOT_REACHED();

I still prefer for loops looping over the main body.

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 385927 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385927&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:299
> > +        for (auto i = priorContent.size(); i--;) {
> > +            auto& previousInlineItem = runs[i].inlineItem;
> 
> This could uses range for and WTF::makeReversedRange
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:304
> > +            ASSERT_NOT_REACHED();
> 
> I still prefer for loops looping over the main body.
oops, my bad.

[zalan]

Committed r253681: <https://trac.webkit.org/changeset/253681>