Bug 205359 - Port service worker code to the HTML5 event loop
Summary: Port service worker code to the HTML5 event loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/web-platform-tests...
Keywords: InRadar
Depends on: 205397
Blocks:
  Show dependency tree / graph
 
Reported: 2019-12-17 14:08 PST by Chris Dumez
Modified: 2019-12-18 08:46 PST (History)
11 users (show)

See Also:

Attachments
Patch (36.95 KB, patch)
2019-12-17 15:14 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-12-17 14:08:04 PST 
Port service worker code to the HTML5 event loop. We're currently mixing using the HTML5 event loop and Document::postTask(), which is causing test flakiness.
Comment 1 Chris Dumez 2019-12-17 15:14:07 PST 
Created attachment 385922 [details]
Patch
Comment 2 Chris Dumez 2019-12-17 18:35:02 PST 
Comment on attachment 385922 [details]
Patch

Clearing flags on attachment: 385922

Committed r253667: <https://trac.webkit.org/changeset/253667>
Comment 3 Chris Dumez 2019-12-17 18:35:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-12-17 18:36:25 PST 
<rdar://problem/58029357>
Comment 5 Truitt Savell 2019-12-18 08:25:39 PST 
It looks like the changes in https://trac.webkit.org/changeset/253667/webkit
caused 32 test crashes, tracking in https://bugs.webkit.org/show_bug.cgi?id=205397
Comment 6 Chris Dumez 2019-12-18 08:38:46 PST 
(In reply to Truitt Savell from comment #5)
> It looks like the changes in https://trac.webkit.org/changeset/253667/webkit
> caused 32 test crashes, tracking in
> https://bugs.webkit.org/show_bug.cgi?id=205397

I am working on it, thanks.
Comment 7 Chris Dumez 2019-12-18 08:46:42 PST 
(In reply to Chris Dumez from comment #6)
> (In reply to Truitt Savell from comment #5)
> > It looks like the changes in https://trac.webkit.org/changeset/253667/webkit
> > caused 32 test crashes, tracking in
> > https://bugs.webkit.org/show_bug.cgi?id=205397
> 
> I am working on it, thanks.

Follow-up landed in <https://trac.webkit.org/changeset/253688> to address the debug assertions.