Bug 20535 - LinearTimingFunction should have control points 0,0,1,1 not 0,0,0,0
Summary: LinearTimingFunction should have control points 0,0,1,1 not 0,0,0,0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-26 17:47 PDT by Simon Fraser (smfr)
Modified: 2008-08-27 11:20 PDT (History)
1 user (show)

See Also:


Attachments
Patch, fixed tests, changelog. (5.41 KB, patch)
2008-08-26 18:05 PDT, Simon Fraser (smfr)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2008-08-26 17:47:32 PDT
getComputedStyle() for transition-timing-function or animation-timing-function returns a cubic-bezier() always. This is OK, but for a linear timing function, it returns cubic-bezier(0,0,0,0). That should be cubic-bezier(0,0,1,1)
Comment 1 Simon Fraser (smfr) 2008-08-26 18:05:17 PDT
Created attachment 23013 [details]
Patch, fixed tests, changelog.
Comment 2 Eric Seidel (no email) 2008-08-27 00:10:49 PDT
Comment on attachment 23013 [details]
Patch, fixed tests, changelog.

Why change CSSStyleSelector if you've changed the default constructor too?

Otherwise looks fine.
Comment 3 Simon Fraser (smfr) 2008-08-27 08:27:24 PDT
I changed CSSStyleSelector because I wanted to make it obvious when creating the linear timing function that the correct control points are being passed.
Comment 4 Darin Adler 2008-08-27 09:52:03 PDT
Comment on attachment 23013 [details]
Patch, fixed tests, changelog.

".0" is strange syntax for a 0 of type double. We normally use "0.0".
Comment 5 Simon Fraser (smfr) 2008-08-27 10:07:53 PDT
I'll fix before committing.
Comment 6 Simon Fraser (smfr) 2008-08-27 11:20:12 PDT
Committed r35943
	M	WebCore/rendering/style/RenderStyle.h
	M	WebCore/ChangeLog
	M	WebCore/css/CSSStyleSelector.cpp
	M	LayoutTests/ChangeLog
	M	LayoutTests/transitions/inherit-other-props-expected.txt
	M	LayoutTests/transitions/inherit-other-props.html
r35943 = e74d671ade9a443887ec1e832811b06adcf182e8 (trunk)