Bug 205338 – WebKitTestRunner should report GPU process crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[youenn fablet]

WebKitTestRunner should report GPU process crashes

[youenn fablet]

Created attachment 385884 [details]
Patch

[youenn fablet]

Created attachment 385885 [details]
Patch

[Tim Horton]

Comment on attachment 385885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385885&action=review

> Source/WebKit/UIProcess/API/C/WKContext.h:108
> +    WKContextChildProcessDidCrashCallback                               gpuProcessDidCrash;
>  } WKContextClientV3;

Don't you need to bump the struct version? Otherwise folks using V3 will be missing one zero in their initializers :P

[youenn fablet]

(In reply to Tim Horton from comment #3)
> Comment on attachment 385885 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385885&action=review
> 
> > Source/WebKit/UIProcess/API/C/WKContext.h:108
> > +    WKContextChildProcessDidCrashCallback                               gpuProcessDidCrash;
> >  } WKContextClientV3;
> 
> Don't you need to bump the struct version? Otherwise folks using V3 will be
> missing one zero in their initializers :P

That should be fine, I bumped the version yesterday to v3 to report service worker process crashes.

[Tim Horton]

Comment on attachment 385885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385885&action=review

>>> Source/WebKit/UIProcess/API/C/WKContext.h:108
>>>  } WKContextClientV3;
>> 
>> Don't you need to bump the struct version? Otherwise folks using V3 will be missing one zero in their initializers :P
> 
> That should be fine, I bumped the version yesterday to v3 to report service worker process crashes.

OH! Nice. Maybe throw a space before the "2" then?

[WebKit Commit Bot]

Comment on attachment 385885 [details]
Patch

Clearing flags on attachment: 385885

Committed r253639: <https://trac.webkit.org/changeset/253639>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58017507>