Bug 205330 – [GTK][WPE] IndexedDB directory set in WebsiteDataManager is ignored

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

There are two problems here:

 1- WebKitWebsiteDataManager is no longer setting the indexedDB directory to the WEbsiteDatastore configuration. It seems the code was removed by mistake in r249778 when rolling out r249768.
 2- The WebProcessPool is not considering the primary WebsiteDataStore for indexedDB configuration.

This was caught by test /webkit/WebKitWebsiteData/configuration

[Carlos Garcia Campos]

Created attachment 385866 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Could a WebKit2 owner check the cross-platform change, please? Youenn?

[youenn fablet]

Comment on attachment 385866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385866&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:540
>          parameters.defaultDataStoreParameters.indexedDatabaseDirectory = WebKit::WebsiteDataStore::defaultDataStore()->parameters().indexedDatabaseDirectory;

LGTM.
There is some pre-existing inconsistencies in this method with withWebsiteDataStore .
Some other parameters like parameters.defaultDataStoreParameters.networkSessionParameters.networkCacheDirectory also check for withWebsiteDataStore.

[Carlos Garcia Campos]

(In reply to youenn fablet from comment #4)
> Comment on attachment 385866 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385866&action=review
> 
> > Source/WebKit/UIProcess/WebProcessPool.cpp:540
> >          parameters.defaultDataStoreParameters.indexedDatabaseDirectory = WebKit::WebsiteDataStore::defaultDataStore()->parameters().indexedDatabaseDirectory;
> 
> LGTM.

Thanks!

> There is some pre-existing inconsistencies in this method with
> withWebsiteDataStore .
> Some other parameters like
> parameters.defaultDataStoreParameters.networkSessionParameters.
> networkCacheDirectory also check for withWebsiteDataStore.

Yes, I noticed it too, but I wasn't sure what the expected behavior was in the end.

[Carlos Garcia Campos]

Committed r253626: <https://trac.webkit.org/changeset/253626>