Bug 205312 - IndexedDB: remove timer for pending operations in IDBTransaction
Summary: IndexedDB: remove timer for pending operations in IDBTransaction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-16 16:29 PST by Sihui Liu
Modified: 2019-12-19 18:05 PST (History)
7 users (show)

See Also:

Attachments
Patch (12.88 KB, patch)
2019-12-16 16:43 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (12.09 KB, patch)
2019-12-16 16:47 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (12.94 KB, patch)
2019-12-19 17:20 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-12-16 16:29:39 PST 
...
Comment 1 Sihui Liu 2019-12-16 16:43:20 PST 
Created attachment 385829 [details]
Patch
Comment 2 Sihui Liu 2019-12-16 16:47:48 PST 
Created attachment 385830 [details]
Patch
Comment 3 Brady Eidson 2019-12-19 10:10:50 PST 
Comment on attachment 385830 [details]
Patch

If no regressions then... yay.

Wish we could have a test that tries to make the web process unresponsive to verify this doesn't regress.
Comment 4 Sihui Liu 2019-12-19 17:17:13 PST 
(In reply to Brady Eidson from comment #3)
> Comment on attachment 385830 [details]
> Patch
> 
> If no regressions then... yay.
> 
> Wish we could have a test that tries to make the web process unresponsive to
> verify this doesn't regress.

We have some stress tests in PerformanceTests/IndexedDB/stress. This change will make PerformanceTests/IndexedDB/stress/large-number-of-inserts-responsiveness.html a bit slower than before (10ms -> ~50ms) as IDB operations now can happen earlier now but so far no proof of web process being unresponsive.
Comment 5 Sihui Liu 2019-12-19 17:20:11 PST 
Created attachment 386166 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-12-19 18:05:00 PST 
Comment on attachment 386166 [details]
Patch for landing

Clearing flags on attachment: 386166

Committed r253807: <https://trac.webkit.org/changeset/253807>
Comment 7 WebKit Commit Bot 2019-12-19 18:05:01 PST 
All reviewed patches have been landed.  Closing bug.