WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
ASSIGNED
205298
Re-tune JSC tests timeout value now that we can timeout based on CPU time.
https://bugs.webkit.org/show_bug.cgi?id=205298
Summary
Re-tune JSC tests timeout value now that we can timeout based on CPU time.
Mark Lam
Reported
2019-12-16 14:01:00 PST
Also (1) investigate removing s_timeoutMultiplier. It was only needed to pad the timeout value for some tests. (2) investigate unskipping tests that were previously flaky due to timeouts.
Attachments
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2019-12-17 15:14:23 PST
After playing with the timeout values for the JSC tests a bit, I came to the following conclusion: (In reply to Mark Lam from
comment #0
)
> Also > (1) investigate removing s_timeoutMultiplier. It was only needed to pad the > timeout value for some tests.
We should keep this option because it allows us to grant more time to certain tests that are intrinsically long running, without having to lengthen the timeout value for all tests. I also think we should not change the current timeout values. Our tests are already tuned for these timeout values. Shortening the timeout values will only cause more churn to add --timeoutMultipliers to the new tests that will start timing out. I don't think there's much value in that given the current timeout value isn't prohibitively long.
> (2) investigate unskipping tests that were previously flaky due to timeouts.
Still need to investigate this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug