Bug 205288 - Add run-time flag for in-app browser privacy
Summary: Add run-time flag for in-app browser privacy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: katherine_cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-16 11:01 PST by katherine_cheney
Modified: 2019-12-17 15:41 PST (History)
5 users (show)

See Also:


Attachments
Patch (8.26 KB, patch)
2019-12-17 12:01 PST, katherine_cheney
no flags Details | Formatted Diff | Diff
Patch (8.21 KB, patch)
2019-12-17 13:53 PST, katherine_cheney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description katherine_cheney 2019-12-16 11:01:02 PST
We should add a flag for the in-app browser privacy feature
Comment 1 katherine_cheney 2019-12-16 11:02:02 PST
<rdar://problem/57569206>
Comment 2 katherine_cheney 2019-12-17 12:01:04 PST
Created attachment 385905 [details]
Patch
Comment 3 John Wilander 2019-12-17 12:07:29 PST
Comment on attachment 385905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385905&action=review

r+ with comments.

I see you've put your setting next to Ad Click Attribution. Since they aren't really related, you don't have to. Please look at the change logs for these files to see where people add new settings unrelated to anything existing, and add yours accordingly. I assume it's append-style.

> Source/WebCore/page/RuntimeEnabledFeatures.h:156
> +    bool inAppBrowserPrivacyEnabled() const { return m_inAppBrowserPrivacyEnabled; }

I know we're not perfect in this regard for these kind of settings, but we should try to use the "is" prefix for getters of booleans.

> Source/WebKit/Shared/WebPreferences.yaml:1536
> +    humanReadableName: "In App Browser Privacy"

Needs a dash in "In-App."

> Source/WebKit/Shared/WebPreferences.yaml:1537
> +    humanReadableDescription: "Enable In App Browser Privacy"

Ditto.

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3526
> +- (BOOL)inAppBrowserPrivacyEnabled

Similar for an "is" prefix.

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:615
> +- (BOOL)inAppBrowserPrivacyEnabled;

Ditto.
Comment 4 katherine_cheney 2019-12-17 13:53:02 PST
Created attachment 385919 [details]
Patch
Comment 5 katherine_cheney 2019-12-17 13:53:53 PST
(In reply to John Wilander from comment #3)
> Comment on attachment 385905 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385905&action=review
> 
> r+ with comments.
> 

Thanks John!
Comment 6 WebKit Commit Bot 2019-12-17 15:40:14 PST
Comment on attachment 385919 [details]
Patch

Clearing flags on attachment: 385919

Committed r253655: <https://trac.webkit.org/changeset/253655>
Comment 7 WebKit Commit Bot 2019-12-17 15:40:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-12-17 15:41:28 PST
<rdar://problem/58024509>