Bug 205281 – Only report prevalent domains in the ResourceLoadStatistics data summary API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

Only prevalent resources should be aggregated for the ResourceLoadStatistics data summary

[Radar WebKit Bug Importer]

<rdar://problem/57975017>

[Kate Cheney]

Created attachment 385833 [details]
Patch

[Kate Cheney]

Created attachment 385840 [details]
Patch

[Kate Cheney]

Fixed failing api test.

[Brent Fulgham]

Comment on attachment 385840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385840&action=review

> LayoutTests/http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-database-expected.txt:16
> +    isPrevalentResource: Yes

Can you confirm we have some tests that verify things are not prevalent if they are beneath the thresholds? I think this is true, but have not checked myself.

> LayoutTests/http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-database-expected.txt:-29
> -Third Party Registrable Domain: localhost

Are these changes because we are no longer returning non-prevelant resources in the ITP data returned by the new API?

[Kate Cheney]

Comment on attachment 385840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385840&action=review

>> LayoutTests/http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-database-expected.txt:16
>> +    isPrevalentResource: Yes
> 
> Can you confirm we have some tests that verify things are not prevalent if they are beneath the thresholds? I think this is true, but have not checked myself.

Yes, this is tested in all of the http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on* tests.

>> LayoutTests/http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-database-expected.txt:-29
>> -Third Party Registrable Domain: localhost
> 
> Are these changes because we are no longer returning non-prevelant resources in the ITP data returned by the new API?

Yes. These tests were never meant to test the ITP data summary, it was just a product of them calling the dumpResourceLoadStatistics function. Now that only prevalent resources are included in the data, the ITP data summary for these non-prevalent domains is empty so they won't report it.

[WebKit Commit Bot]

Comment on attachment 385840 [details]
Patch

Clearing flags on attachment: 385840

Committed r253697: <https://trac.webkit.org/changeset/253697>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.