Bug 205267 - WebKitTestRunner should report service worker process crashes
Summary: WebKitTestRunner should report service worker process crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-16 06:40 PST by youenn fablet
Modified: 2019-12-17 03:34 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.75 KB, patch)
2019-12-16 06:43 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (9.13 KB, patch)
2019-12-16 07:07 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (9.11 KB, patch)
2019-12-17 00:25 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-16 06:40:59 PST 
Currently service worker crashes are only reported if a page lives in the process.
Comment 1 youenn fablet 2019-12-16 06:43:38 PST 
Created attachment 385760 [details]
Patch
Comment 2 youenn fablet 2019-12-16 07:07:24 PST 
Created attachment 385761 [details]
Patch
Comment 3 Chris Dumez 2019-12-16 12:25:17 PST 
Comment on attachment 385761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385761&action=review

> Source/WebKit/UIProcess/API/C/WKContext.h:106
> +    WKContextNetworkProcessDidCrashCallback                             serviceWorkerProcessDidCrash;

WKContextNetworkProcessDidCrashCallback -> WKContextChildProcessDidCrashCallback
or introduce a new typedef for the service worker. It is very confusing to have a Callback with NetworkProcess in there, even though it gets called for the ServiceWorkerProcess.
Comment 4 youenn fablet 2019-12-17 00:25:50 PST 
Created attachment 385861 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-12-17 03:33:24 PST 
Comment on attachment 385861 [details]
Patch for landing

Clearing flags on attachment: 385861

Committed r253620: <https://trac.webkit.org/changeset/253620>
Comment 6 WebKit Commit Bot 2019-12-17 03:33:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-17 03:34:19 PST 
<rdar://problem/58002362>