Bug 205261 - http/wpt/service-workers/postMessage-fetch-order.https.html is a flaky failure after r253528
Summary: http/wpt/service-workers/postMessage-fetch-order.https.html is a flaky failur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-16 02:53 PST by youenn fablet
Modified: 2019-12-16 08:17 PST (History)
2 users (show)

See Also:


Attachments
Patch (10.01 KB, patch)
2019-12-16 03:08 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (12.73 KB, patch)
2019-12-16 05:25 PST, youenn fablet
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-16 02:53:46 PST
http/wpt/service-workers/postMessage-fetch-order.https.html is a flaky failure after r253528
Comment 1 youenn fablet 2019-12-16 03:08:57 PST
Created attachment 385747 [details]
Patch
Comment 2 youenn fablet 2019-12-16 05:25:29 PST
Created attachment 385754 [details]
Patch
Comment 3 Chris Dumez 2019-12-16 08:09:36 PST
Comment on attachment 385754 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385754&action=review

> Source/WebKit/ChangeLog:8
> +        Instead of starting the fetch task asycnhronously, start it synchronously but make sure that

typo: asycnhronously

> Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:179
>      // Signal load failure for them

Missing period at the end.
Comment 4 Chris Dumez 2019-12-16 08:16:04 PST
Committed r253554: <https://trac.webkit.org/changeset/253554>
Comment 5 Radar WebKit Bug Importer 2019-12-16 08:17:24 PST
<rdar://problem/57969320>