RESOLVED FIXED 205257
[LFC][IFC] Rename LineBuilder::m_skipAlignment to LineBuilder::m_intrinsicWidthLine 
https://bugs.webkit.org/show_bug.cgi?id=205257
Summary [LFC][IFC] Rename LineBuilder::m_skipAlignment to LineBuilder::m_intrinsicWid...
zalan
Reported 2019-12-15 19:08:33 PST
it's going to be used for hanging glyphs.
Attachments
Patch (7.44 KB, patch)
2019-12-15 19:15 PST, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-15 19:08:52 PST
<rdar://problem/57955958>
zalan
Comment 2 2019-12-15 19:15:39 PST
Created attachment 385731 [details] Patch
Antti Koivisto
Comment 3 2019-12-15 23:24:25 PST
Comment on attachment 385731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385731&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:248 > + bool m_intrinsicWidthLine { false }; m_isIntrinsicWidthLine? m_hasIntrinsicWidthForLine?
Antti Koivisto
Comment 4 2019-12-16 00:27:28 PST
Or just m_hasIntrinsicWidth. It is all about a line anyway.
zalan
Comment 5 2019-12-16 06:49:15 PST
Committed r253550: <https://trac.webkit.org/changeset/253550>
zalan
Comment 6 2019-12-16 06:54:52 PST
(In reply to Antti Koivisto from comment #4) > Or just m_hasIntrinsicWidth. It is all about a line anyway. I went with m_isIntrinsicSizing to follow the enum's name (and this variable indicates that we are in the intrinsic sizing phase).
Note You need to log in before you can comment on or make changes to this bug.