RESOLVED FIXED 205250
[GTK] Build with USE_WPE_RENDERER=No fails with undefined EGL_WAYLAND_BUFFER_WL, 
https://bugs.webkit.org/show_bug.cgi?id=205250
Summary [GTK] Build with USE_WPE_RENDERER=No fails with undefined EGL_WAYLAND_BUFFER_WL,
Emilio Cobos Álvarez (:emilio)
Reported 2019-12-15 05:45:28 PST
.
Attachments
Patch (1.31 KB, patch)
2019-12-15 05:47 PST, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2019-12-16 05:59 PST, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emilio Cobos Álvarez (:emilio)
Comment 1 2019-12-15 05:47:38 PST
Created attachment 385714 [details] Patch
Carlos Garcia Campos
Comment 2 2019-12-16 02:27:36 PST
Comment on attachment 385714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385714&action=review > Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp:34 > +#include <EGL/eglmesaext.h> Is this header mesa specific? I think we could define it below inside the the #if !defined(PFNEGLBINDWAYLANDDISPLAYWL) for example, or using its own ifdef #define EGL_WAYLAND_BUFFER_WL 0x31D5 We will handle the runtijme failure correctly if the required APIs are not availbale at runtime.
Emilio Cobos Álvarez (:emilio)
Comment 3 2019-12-16 05:59:05 PST
Created attachment 385757 [details] Patch
Emilio Cobos Álvarez (:emilio)
Comment 4 2019-12-16 06:02:56 PST
(In reply to Carlos Garcia Campos from comment #2) > Is this header mesa specific? I think we could define it below inside the > the #if !defined(PFNEGLBINDWAYLANDDISPLAYWL) for example, or using its own > ifdef > > #define EGL_WAYLAND_BUFFER_WL 0x31D5 > > We will handle the runtijme failure correctly if the required APIs are not > availbale at runtime. Sure, that wfm.
WebKit Commit Bot
Comment 5 2019-12-16 07:56:25 PST
Comment on attachment 385757 [details] Patch Clearing flags on attachment: 385757 Committed r253553: <https://trac.webkit.org/changeset/253553>
WebKit Commit Bot
Comment 6 2019-12-16 07:56:27 PST
All reviewed patches have been landed. Closing bug.
Adrian Perez
Comment 7 2020-07-23 15:43:01 PDT
*** Bug 204108 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.