Bug 205250 - [GTK] Build with USE_WPE_RENDERER=No fails with undefined EGL_WAYLAND_BUFFER_WL,
Summary: [GTK] Build with USE_WPE_RENDERER=No fails with undefined EGL_WAYLAND_BUFFER_WL,
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emilio Cobos Álvarez (:emilio)
URL:
Keywords:
: 204108 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-12-15 05:45 PST by Emilio Cobos Álvarez (:emilio)
Modified: 2020-07-23 15:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2019-12-15 05:47 PST, Emilio Cobos Álvarez (:emilio) 		no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2019-12-16 05:59 PST, Emilio Cobos Álvarez (:emilio) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2019-12-15 05:45:28 PST 
.
Comment 1 Emilio Cobos Álvarez (:emilio) 2019-12-15 05:47:38 PST 
Created attachment 385714 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-12-16 02:27:36 PST 
Comment on attachment 385714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385714&action=review

> Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp:34
> +#include <EGL/eglmesaext.h>

Is this header mesa specific? I think we could define it below inside the the #if !defined(PFNEGLBINDWAYLANDDISPLAYWL) for example, or using its own ifdef

#define EGL_WAYLAND_BUFFER_WL 0x31D5

We will handle the runtijme failure correctly if the required APIs are not availbale at runtime.
Comment 3 Emilio Cobos Álvarez (:emilio) 2019-12-16 05:59:05 PST 
Created attachment 385757 [details]
Patch
Comment 4 Emilio Cobos Álvarez (:emilio) 2019-12-16 06:02:56 PST 
(In reply to Carlos Garcia Campos from comment #2)
> Is this header mesa specific? I think we could define it below inside the
> the #if !defined(PFNEGLBINDWAYLANDDISPLAYWL) for example, or using its own
> ifdef
> 
> #define EGL_WAYLAND_BUFFER_WL 0x31D5
> 
> We will handle the runtijme failure correctly if the required APIs are not
> availbale at runtime.

Sure, that wfm.
Comment 5 WebKit Commit Bot 2019-12-16 07:56:25 PST 
Comment on attachment 385757 [details]
Patch

Clearing flags on attachment: 385757

Committed r253553: <https://trac.webkit.org/changeset/253553>
Comment 6 WebKit Commit Bot 2019-12-16 07:56:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Adrian Perez 2020-07-23 15:43:01 PDT 
*** Bug 204108 has been marked as a duplicate of this bug. ***