RESOLVED FIXED 205244
[LFC][IFC] Introduce LineBreaker::PartialRun 
https://bugs.webkit.org/show_bug.cgi?id=205244
Summary [LFC][IFC] Introduce LineBreaker::PartialRun
zalan
Reported 2019-12-14 21:15:50 PST
Use it instead of LineBreaker::LeftSide
Attachments
Patch (12.63 KB, patch)
2019-12-14 21:19 PST, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-14 21:16:15 PST
<rdar://problem/57943825>
zalan
Comment 2 2019-12-14 21:19:32 PST
Created attachment 385707 [details] Patch
Antti Koivisto
Comment 3 2019-12-14 23:48:51 PST
Comment on attachment 385707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385707&action=review > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:154 > if (auto leftSide = tryBreakingTextRun(run, adjustedAvailableWidth, lineStatus.lineIsEmpty)) Would 'leftSide' better be named as 'partialRun'? > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:168 > if (auto leftSide = tryBreakingTextRun(run, maxInlineLayoutUnit(), lineStatus.lineIsEmpty)) { Here too
zalan
Comment 4 2019-12-15 05:36:40 PST
Committed r253532: <https://trac.webkit.org/changeset/253532>
Note You need to log in before you can comment on or make changes to this bug.