Bug 205243 - python3: wpt exporter should parse a patch as bytes
Summary: python3: wpt exporter should parse a patch as bytes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-14 19:44 PST by Emilio Cobos Álvarez (:emilio)
Modified: 2019-12-16 15:02 PST (History)
6 users (show)

See Also:

Attachments
Output of webkit-patch-upload -g HEAD (2.66 KB, text/plain)
2019-12-14 19:44 PST, Emilio Cobos Álvarez (:emilio) 		no flags Details
Patch (6.96 KB, patch)
2019-12-16 08:20 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2019-12-14 19:44:24 PST 
Created attachment 385706 [details]
Output of webkit-patch-upload -g HEAD

When trying to attach a patch to bug 117769, it threw, see the attached patch.
Comment 1 Emilio Cobos Álvarez (:emilio) 2019-12-14 19:44:45 PST 
(In reply to Emilio Cobos Álvarez (:emilio) from comment #0)
> When trying to attach a patch to bug 117769, it threw, see the attached
> patch.

The attached output, that is :)
Comment 2 Jonathan Bedard 2019-12-16 07:48:25 PST 
(In reply to Emilio Cobos Álvarez (:emilio) from comment #0)
> Created attachment 385706 [details]
> Output of webkit-patch-upload -g HEAD
> 
> When trying to attach a patch to bug 117769, it threw, see the attached
> patch.

webkit-patch-upload isn't a WebKit script.

Do you mean 'webkit-patch upload -g HEAD'?
Comment 3 Emilio Cobos Álvarez (:emilio) 2019-12-16 07:58:27 PST 
Yes, sorry.
Comment 4 Jonathan Bedard 2019-12-16 08:20:31 PST 
Created attachment 385770 [details]
Patch
Comment 5 Jonathan Bedard 2019-12-16 08:22:38 PST 
I don't actually have a git checkout, so I can't 100% replicate Emilio's configuration, but our unit tests were passing around patches as strings, which meant that we weren't correctly covering this case, so I'm pretty confident this is our fix.
Comment 6 WebKit Commit Bot 2019-12-16 15:01:14 PST 
Comment on attachment 385770 [details]
Patch

Clearing flags on attachment: 385770

Committed r253587: <https://trac.webkit.org/changeset/253587>
Comment 7 WebKit Commit Bot 2019-12-16 15:01:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-12-16 15:02:39 PST 
<rdar://problem/57986684>