WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
205238
Remove the "needsFullOrderingComparisons" feature from PODRedBlackTree
https://bugs.webkit.org/show_bug.cgi?id=205238
Summary
Remove the "needsFullOrderingComparisons" feature from PODRedBlackTree
Darin Adler
Reported
2019-12-14 11:10:03 PST
Remove the "needsFullOrderingComparisons" feature from PODRedBlackTree
Attachments
Patch
(30.75 KB, patch)
2019-12-14 11:20 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(30.78 KB, patch)
2019-12-20 11:11 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(30.97 KB, patch)
2020-01-12 11:17 PST
,
Darin Adler
sam
: review+
sam
: commit-queue+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2019-12-14 11:20:49 PST
Comment hidden (obsolete)
Created
attachment 385695
[details]
Patch
Darin Adler
Comment 2
2019-12-20 09:53:10 PST
Comment hidden (obsolete)
I am not able to reproduce the mac-wk2 EWS test failure locally. Re-running the test.
Darin Adler
Comment 3
2019-12-20 11:11:01 PST
Comment hidden (obsolete)
Created
attachment 386227
[details]
Patch
Darin Adler
Comment 4
2019-12-20 14:04:28 PST
Comment hidden (obsolete)
Comment on
attachment 386227
[details]
Patch Seems to me that the media/track/track-cue-rendering-horizontal.html must be a real regression. I wonder why i can’t reproduce it locally.
Darin Adler
Comment 5
2020-01-02 16:23:26 PST
Comment hidden (obsolete)
No that failure went away when I retried the EWS.
Darin Adler
Comment 6
2020-01-12 11:17:25 PST
Created
attachment 387479
[details]
Patch
Darin Adler
Comment 7
2020-01-12 15:07:34 PST
OK, worked around the Windows build failure, all tests are passing, so this is now ready for review.
Darin Adler
Comment 8
2020-01-13 08:48:42 PST
I have another patch to follow this one with further refinements, but I think it’s best to land this is smaller incremental steps. So I want to get this reviewed and landed as-is.
Sam Weinig
Comment 9
2020-01-13 17:41:33 PST
Comment on
attachment 387479
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=387479&action=review
> Source/WebCore/platform/PODInterval.h:3 > + * Copyright (C) 2019 Apple Inc. All rights reserved.
2020!
Darin Adler
Comment 10
2020-01-13 19:18:13 PST
Committed
r254483
: <
https://trac.webkit.org/changeset/254483
>
Radar WebKit Bug Importer
Comment 11
2020-01-13 19:19:10 PST
<
rdar://problem/58554372
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug