Bug 205236 - [iOS] The WebContent process should not use API to get the user interface idiom
Summary: [iOS] The WebContent process should not use API to get the user interface idiom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-14 10:50 PST by Per Arne Vollan
Modified: 2020-01-10 14:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (24.92 KB, patch)
2019-12-14 11:09 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (24.95 KB, patch)
2019-12-14 11:32 PST, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (24.96 KB, patch)
2019-12-17 16:47 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (993 bytes, patch)
2019-12-17 17:49 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-12-14 10:50:11 PST 
This should be done in the UI process, since using the API in the WebContent process will connect to daemons we intend to block access to.
Comment 1 Per Arne Vollan 2019-12-14 11:09:04 PST 
Created attachment 385692 [details]
Patch
Comment 2 Per Arne Vollan 2019-12-14 11:32:42 PST 
Created attachment 385696 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2019-12-16 07:17:03 PST 
<rdar://problem/57967913>
Comment 4 Brent Fulgham 2019-12-17 16:27:09 PST 
Comment on attachment 385696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385696&action=review

r=me

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2929
> +            return !WebKit::currentUserInterfaceIdiomIsPad();

Incorrect indentation.
Comment 5 Per Arne Vollan 2019-12-17 16:35:55 PST 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 385696 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385696&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2929
> > +            return !WebKit::currentUserInterfaceIdiomIsPad();
> 
> Incorrect indentation.

Thanks for reviewing!
Comment 6 Per Arne Vollan 2019-12-17 16:47:44 PST 
Created attachment 385929 [details]
Patch
Comment 7 WebKit Commit Bot 2019-12-17 17:32:48 PST 
Comment on attachment 385929 [details]
Patch

Clearing flags on attachment: 385929

Committed r253661: <https://trac.webkit.org/changeset/253661>
Comment 8 Per Arne Vollan 2019-12-17 17:49:39 PST 
Created attachment 385931 [details]
Patch
Comment 9 Per Arne Vollan 2019-12-17 17:50:48 PST 
(In reply to Per Arne Vollan from comment #8)
> Created attachment 385931 [details]
> Patch

Added patch to address iOS build failure. Will land as soon as it compiles successfully on iOS.
Comment 10 Per Arne Vollan 2019-12-17 17:55:53 PST 
(In reply to Per Arne Vollan from comment #9)
> (In reply to Per Arne Vollan from comment #8)
> > Created attachment 385931 [details]
> > Patch
> 
> Added patch to address iOS build failure. Will land as soon as it compiles
> successfully on iOS.

Landed https://trac.webkit.org/changeset/253663/webkit.