Bug 205236 – [iOS] The WebContent process should not use API to get the user interface idiom

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

This should be done in the UI process, since using the API in the WebContent process will connect to daemons we intend to block access to.

[Per Arne Vollan]

Created attachment 385692 [details]
Patch

[Per Arne Vollan]

Created attachment 385696 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/57967913>

[Brent Fulgham]

Comment on attachment 385696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385696&action=review

r=me

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2929
> +            return !WebKit::currentUserInterfaceIdiomIsPad();

Incorrect indentation.

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 385696 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385696&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2929
> > +            return !WebKit::currentUserInterfaceIdiomIsPad();
> 
> Incorrect indentation.

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 385929 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 385929 [details]
Patch

Clearing flags on attachment: 385929

Committed r253661: <https://trac.webkit.org/changeset/253661>

[Per Arne Vollan]

Created attachment 385931 [details]
Patch

[Per Arne Vollan]

(In reply to Per Arne Vollan from comment #8)
> Created attachment 385931 [details]
> Patch

Added patch to address iOS build failure. Will land as soon as it compiles successfully on iOS.

[Per Arne Vollan]

(In reply to Per Arne Vollan from comment #9)
> (In reply to Per Arne Vollan from comment #8)
> > Created attachment 385931 [details]
> > Patch
> 
> Added patch to address iOS build failure. Will land as soon as it compiles
> successfully on iOS.

Landed https://trac.webkit.org/changeset/253663/webkit.