Bug 205226 – REGRSSION: [ High Sierra Catalina ] (r253310) compositing/video/video-border-radius-clipping.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Compositing

[Truitt Savell]

The changes in https://trac.webkit.org/changeset/253310/webkit has caused compositing/video/video-border-radius-clipping.html to become a constant failure on High Sierra and Catalina wk1

history:
https://results.webkit.org/?suite=layout-tests&test=compositing%2Fvideo%2Fvideo-border-radius-clipping.html

Diff:
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r253485%20(17701)/compositing/video/video-border-radius-clipping-diffs.html

Looks like a single pixel difference.

[Radar WebKit Bug Importer]

<rdar://problem/57929456>

[Simon Fraser (smfr)]

I really wish we had per-test fuzziness for ref tests. These tests both use the same video, at the same time, but are off by a tiny bit.

[Maciej Stachowiak]

Maybe we should add per-test fuzziness?

[Simon Fraser (smfr)]

Alexey has historically objected: bug 149828.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/253647/webkit

[Alexey Proskuryakov]

Why was this marked as RESOLVED/FIXED? Only an expectation was landed, there was no fix here.

[Simon Fraser (smfr)]

I marked as as a failure for those platforms (High Sierra, WK1) where it's flakey. We have test coverage on WK2/Mojave where it doesn't flake.

[Alexey Proskuryakov]

It flakes on WK2 too, see bug 206614.

[Peng Liu]

Created attachment 388894 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 388894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388894&action=review

> LayoutTests/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=205226

Is this expected to address https://bugs.webkit.org/show_bug.cgi?id=206614 too?

[Peng Liu]

*** Bug 206614 has been marked as a duplicate of this bug. ***

[Peng Liu]

(In reply to Alexey Proskuryakov from comment #10)
> Comment on attachment 388894 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388894&action=review
> 
> > LayoutTests/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=205226
> 
> Is this expected to address https://bugs.webkit.org/show_bug.cgi?id=206614
> too?

I think so. I have verified that with my local build.

[WebKit Commit Bot]

Comment on attachment 388894 [details]
Patch

Clearing flags on attachment: 388894

Committed r255215: <https://trac.webkit.org/changeset/255215>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.