Bug 205214 – Add an option to run_webkit_tests.py to enable all GPU process related features and choose the additional expectations

• Status: NEW
• Component: New Bugs

[Peng Liu]

Add an option to run_webkit_tests.py to enable all GPU process related features and choose the additional expectations

[Radar WebKit Bug Importer]

<rdar://problem/57920116>

[Jonathan Bedard]

This option should also set the flavor of the result upload.

[Peng Liu]

Created attachment 385628 [details]
WIP

[Jonathan Bedard]

Comment on attachment 385628 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=385628&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:379
> +        options.internal_feature.append('CaptureAudioInGPUProcessEnabled')

Actually, we're only missing result-report-flavor....just adding:

if options.result_report_flavor:
    raise RuntimeError('--gpu-process-features implicitly sets the result flavor, this should not be overridden')
options.result_report_flavor = 'gpuprocess'

[Tim Horton]

Comment on attachment 385628 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=385628&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:328
> +            "--gpu-process-features", action="store_true", default=False,

IMO "--use-gpu-process"

[Peng Liu]

Created attachment 385636 [details]
Patch

[Peng Liu]

Comment on attachment 385628 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=385628&action=review

>> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:328
>> +            "--gpu-process-features", action="store_true", default=False,
> 
> IMO "--use-gpu-process"

Fixed.

>> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:379
>> +        options.internal_feature.append('CaptureAudioInGPUProcessEnabled')
> 
> Actually, we're only missing result-report-flavor....just adding:
> 
> if options.result_report_flavor:
>     raise RuntimeError('--gpu-process-features implicitly sets the result flavor, this should not be overridden')
> options.result_report_flavor = 'gpuprocess'

Got it, thanks!

[Tim Horton]

Comment on attachment 385636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385636&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:329
> +            help=("Enable all GPU process related features. Equivalent to '--internal-feature=useGPUProcessForMedia --internal-feature=CaptureAudioInGPUProcessEnabled --additional-expectations=LayoutTests/gpu-process/TestExpectations'")),

I wonder if we should avoid listing the --internal-features in the help here, because people are going to change the set, and probably not change this list. ALSO, you still have a lower-case u in "useGPUProcessForMedia" here.

[Peng Liu]

Created attachment 385638 [details]
Patch

[Peng Liu]

Comment on attachment 385636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385636&action=review

>> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:329
>> +            help=("Enable all GPU process related features. Equivalent to '--internal-feature=useGPUProcessForMedia --internal-feature=CaptureAudioInGPUProcessEnabled --additional-expectations=LayoutTests/gpu-process/TestExpectations'")),
> 
> I wonder if we should avoid listing the --internal-features in the help here, because people are going to change the set, and probably not change this list. ALSO, you still have a lower-case u in "useGPUProcessForMedia" here.

Right!

[WebKit Commit Bot]

Comment on attachment 385638 [details]
Patch

Clearing flags on attachment: 385638

Committed r253512: <https://trac.webkit.org/changeset/253512>