Bug 205214 - Add an option to run_webkit_tests.py to enable all GPU process related features and choose the additional expectations
Summary: Add an option to run_webkit_tests.py to enable all GPU process related featur...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-13 11:55 PST by Peng Liu
Modified: 2019-12-13 17:20 PST (History)
7 users (show)

See Also:

Attachments
WIP (2.52 KB, patch)
2019-12-13 12:06 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Patch (2.78 KB, patch)
2019-12-13 13:13 PST, Peng Liu 		thorton: review+
Details | Formatted Diff | Diff
Patch (2.67 KB, patch)
2019-12-13 13:37 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2019-12-13 11:55:04 PST 
Add an option to run_webkit_tests.py to enable all GPU process related features and choose the additional expectations
Comment 1 Radar WebKit Bug Importer 2019-12-13 11:57:20 PST 
<rdar://problem/57920116>
Comment 2 Jonathan Bedard 2019-12-13 11:57:58 PST 
This option should also set the flavor of the result upload.
Comment 3 Peng Liu 2019-12-13 12:06:20 PST 
Created attachment 385628 [details]
WIP
Comment 4 Jonathan Bedard 2019-12-13 12:11:49 PST 
Comment on attachment 385628 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=385628&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:379
> +        options.internal_feature.append('CaptureAudioInGPUProcessEnabled')

Actually, we're only missing result-report-flavor....just adding:

if options.result_report_flavor:
    raise RuntimeError('--gpu-process-features implicitly sets the result flavor, this should not be overridden')
options.result_report_flavor = 'gpuprocess'
Comment 5 Tim Horton 2019-12-13 12:16:07 PST 
Comment on attachment 385628 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=385628&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:328
> +            "--gpu-process-features", action="store_true", default=False,

IMO "--use-gpu-process"
Comment 6 Peng Liu 2019-12-13 13:13:26 PST 
Created attachment 385636 [details]
Patch
Comment 7 Peng Liu 2019-12-13 13:15:18 PST 
Comment on attachment 385628 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=385628&action=review

>> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:328
>> +            "--gpu-process-features", action="store_true", default=False,
> 
> IMO "--use-gpu-process"

Fixed.

>> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:379
>> +        options.internal_feature.append('CaptureAudioInGPUProcessEnabled')
> 
> Actually, we're only missing result-report-flavor....just adding:
> 
> if options.result_report_flavor:
>     raise RuntimeError('--gpu-process-features implicitly sets the result flavor, this should not be overridden')
> options.result_report_flavor = 'gpuprocess'

Got it, thanks!
Comment 8 Tim Horton 2019-12-13 13:28:43 PST 
Comment on attachment 385636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385636&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:329
> +            help=("Enable all GPU process related features. Equivalent to '--internal-feature=useGPUProcessForMedia --internal-feature=CaptureAudioInGPUProcessEnabled --additional-expectations=LayoutTests/gpu-process/TestExpectations'")),

I wonder if we should avoid listing the --internal-features in the help here, because people are going to change the set, and probably not change this list. ALSO, you still have a lower-case u in "useGPUProcessForMedia" here.
Comment 9 Peng Liu 2019-12-13 13:37:53 PST 
Created attachment 385638 [details]
Patch
Comment 10 Peng Liu 2019-12-13 13:38:43 PST 
Comment on attachment 385636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385636&action=review

>> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:329
>> +            help=("Enable all GPU process related features. Equivalent to '--internal-feature=useGPUProcessForMedia --internal-feature=CaptureAudioInGPUProcessEnabled --additional-expectations=LayoutTests/gpu-process/TestExpectations'")),
> 
> I wonder if we should avoid listing the --internal-features in the help here, because people are going to change the set, and probably not change this list. ALSO, you still have a lower-case u in "useGPUProcessForMedia" here.

Right!
Comment 11 WebKit Commit Bot 2019-12-13 17:20:55 PST 
Comment on attachment 385638 [details]
Patch

Clearing flags on attachment: 385638

Committed r253512: <https://trac.webkit.org/changeset/253512>