Bug 205211 - Add a Heap::finalize function that takes WTF::Function<void()>
Summary: Add a Heap::finalize function that takes WTF::Function<void()>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-13 11:37 PST by Saam Barati
Modified: 2019-12-13 14:38 PST (History)
19 users (show)

See Also:

Attachments
patch (4.83 KB, patch)
2019-12-13 12:04 PST, Saam Barati 		ggaren: review+
Details | Formatted Diff | Diff
patch for landing (5.73 KB, patch)
2019-12-13 12:33 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-12-13 11:37:52 PST 
...
Comment 1 Saam Barati 2019-12-13 12:04:32 PST 
Created attachment 385627 [details]
patch

This should work. Going to test it now.
Comment 2 Geoffrey Garen 2019-12-13 12:13:09 PST 
Comment on attachment 385627 [details]
patch

r=me

I would prefer to use a separate FinalizerOwner rather than bit masking the pointer because it would be a little clearer.
Comment 3 Saam Barati 2019-12-13 12:33:04 PST 
Created attachment 385631 [details]
patch for landing
Comment 4 WebKit Commit Bot 2019-12-13 14:37:59 PST 
Comment on attachment 385631 [details]
patch for landing

Clearing flags on attachment: 385631

Committed r253500: <https://trac.webkit.org/changeset/253500>
Comment 5 WebKit Commit Bot 2019-12-13 14:38:01 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-12-13 14:38:31 PST 
<rdar://problem/57925827>