We often get bugs from users who turn on paint flashing or compositing borders, close Web Inspector, reopen Web Inspector, and are then surprised when the page flashes red or these borders exist all over the page. Given that the dark mode and print styles toggles are limited to the Web Inspector session, we should make these have the same behavior.
Created attachment 385581 [details] Patch
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment on attachment 385581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385581&action=review > Source/WebCore/page/Settings.yaml:147 > + inspectorOverride: true Slick, I didn't know about this.
Comment on attachment 385581 [details] Patch Rejecting attachment 385581 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 385581, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=385581&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=205201&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 385581 from bug 205201. Fetching: https://bugs.webkit.org/attachment.cgi?id=385581 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 11 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/inspector/protocol/Page.json patching file Source/WebCore/inspector/agents/InspectorPageAgent.cpp patching file Source/WebCore/inspector/agents/InspectorPageAgent.h patching file Source/WebCore/page/Settings.yaml patching file Source/WebInspectorUI/UserInterface/Base/Main.js Hunk #1 succeeded at 583 (offset 1 line). patching file Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js patching file Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js Hunk #1 succeeded at 51 with fuzz 1. Hunk #2 succeeded at 144 (offset -7 lines). Hunk #3 FAILED at 163. Hunk #4 succeeded at 378 (offset -8 lines). Hunk #5 succeeded at 595 with fuzz 1 (offset -8 lines). 1 out of 5 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js.rej patching file Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13292956
Created attachment 386067 [details] Patch
Created attachment 386068 [details] Patch Oops, bad rebase
Comment on attachment 386068 [details] Patch Clearing flags on attachment: 386068 Committed r253739: <https://trac.webkit.org/changeset/253739>
All reviewed patches have been landed. Closing bug.
<rdar://problem/58070760>