Bug 205196 – Prefix CSS selectors with all applicable CSS groupings when generating a ChangeLog

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Devin Rousso]

When modifying a style inside a @media grouping, `prepare-ChangeLog` currently adds the media query as a separate line instead of prefixing the modified rule's selector.

e.g., modifying
```
    @media (prefers-color-scheme: dark) {
        body {
            ...
        }
        div {
            ...
        }
    }
```
would generate
```
    (@media (prefers-color-scheme: dark)):
    (body):
    (div):
```
instead of
```
    (@media (prefers-color-scheme: dark) body):
    (@media (prefers-color-scheme: dark) div):
```

[Devin Rousso]

Created attachment 385574 [details]
Patch

[Devin Rousso]

Created attachment 385575 [details]
Patch

Oops.  Forgot bug number :P

[Joseph Pecoraro]

Comment on attachment 385575 [details]
Patch

This also needs tests. See  Tools/Scripts/webkitperl/prepare-ChangeLog_unittest

[Joseph Pecoraro]

> would generate
> ```
>     (@media (prefers-color-scheme: dark)):
>     (body):
>     (div):
> ```
> instead of
> ```
>     (@media (prefers-color-scheme: dark) body):
>     (@media (prefers-color-scheme: dark) div):
> ```

Awesome!!

[Devin Rousso]

Created attachment 385589 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 385589 [details]
Patch

Clearing flags on attachment: 385589

Committed r253478: <https://trac.webkit.org/changeset/253478>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57913269>

[Joseph Pecoraro]

Comment on attachment 385589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385589&action=review

> Tools/Scripts/prepare-ChangeLog:1906
> +                            $groupingPrefix .= " "

Normally perl requires a semicolon. This happens to be the last statement of a block so it isn't required but it would be good to have.