Bug 205195 – Teach prepare-ChangeLog about JavaScript async functions

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Devin Rousso]

Something like `async foo()` shows up as `(async.foo):` in a ChangeLog, when it really should be `(async foo):`.  This would match `get`, `set` and `static`.

[Devin Rousso]

Created attachment 385573 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 385573 [details]
Patch

Awesome!

But Needs tests:
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js

That way we see the ChangeLog for this patch itself in action.

[Devin Rousso]

Created attachment 385588 [details]
Patch

[Jonathan Bedard]

Comment on attachment 385588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385588&action=review

> Tools/Scripts/prepare-ChangeLog:1705
> +                my $currentFunction = join('.', (@currentScopes, ($mode eq 'class' and !$staticOrContructorSeen) ? "prototype" : "", @currentIdentifiers));

This seems unrelated to the async changes, what's going on here?

[Devin Rousso]

Comment on attachment 385588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385588&action=review

>> Tools/Scripts/prepare-ChangeLog:1705
>> +                my $currentFunction = join('.', (@currentScopes, ($mode eq 'class' and !$staticOrContructorSeen) ? "prototype" : "", @currentIdentifiers));
> 
> This seems unrelated to the async changes, what's going on here?

This prevents the `static async staticAsync` member function from being shown as `AsyncFuncClass.prototype.async staticAsync`, which is not accurate since the `static` means that it's not added to the `prototype`.

[WebKit Commit Bot]

Comment on attachment 385588 [details]
Patch

Clearing flags on attachment: 385588

Committed r253490: <https://trac.webkit.org/changeset/253490>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57919141>