Something like `async foo()` shows up as `(async.foo):` in a ChangeLog, when it really should be `(async foo):`. This would match `get`, `set` and `static`.
Created attachment 385573 [details] Patch
Comment on attachment 385573 [details] Patch Awesome! But Needs tests: Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js That way we see the ChangeLog for this patch itself in action.
Created attachment 385588 [details] Patch
Comment on attachment 385588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385588&action=review > Tools/Scripts/prepare-ChangeLog:1705 > + my $currentFunction = join('.', (@currentScopes, ($mode eq 'class' and !$staticOrContructorSeen) ? "prototype" : "", @currentIdentifiers)); This seems unrelated to the async changes, what's going on here?
Comment on attachment 385588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385588&action=review >> Tools/Scripts/prepare-ChangeLog:1705 >> + my $currentFunction = join('.', (@currentScopes, ($mode eq 'class' and !$staticOrContructorSeen) ? "prototype" : "", @currentIdentifiers)); > > This seems unrelated to the async changes, what's going on here? This prevents the `static async staticAsync` member function from being shown as `AsyncFuncClass.prototype.async staticAsync`, which is not accurate since the `static` means that it's not added to the `prototype`.
Comment on attachment 385588 [details] Patch Clearing flags on attachment: 385588 Committed r253490: <https://trac.webkit.org/changeset/253490>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57919141>