Bug 205195 - Teach prepare-ChangeLog about JavaScript async functions
Summary: Teach prepare-ChangeLog about JavaScript async functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-12 21:32 PST by Devin Rousso
Modified: 2019-12-13 11:32 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.32 KB, patch)
2019-12-12 21:32 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (5.21 KB, patch)
2019-12-13 02:27 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-12-12 21:32:27 PST
Something like `async foo()` shows up as `(async.foo):` in a ChangeLog, when it really should be `(async foo):`.  This would match `get`, `set` and `static`.
Comment 1 Devin Rousso 2019-12-12 21:32:58 PST
Created attachment 385573 [details]
Patch
Comment 2 Joseph Pecoraro 2019-12-12 23:07:38 PST
Comment on attachment 385573 [details]
Patch

Awesome!

But Needs tests:
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js

That way we see the ChangeLog for this patch itself in action.
Comment 3 Devin Rousso 2019-12-13 02:27:32 PST
Created attachment 385588 [details]
Patch
Comment 4 Jonathan Bedard 2019-12-13 07:39:55 PST
Comment on attachment 385588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385588&action=review

> Tools/Scripts/prepare-ChangeLog:1705
> +                my $currentFunction = join('.', (@currentScopes, ($mode eq 'class' and !$staticOrContructorSeen) ? "prototype" : "", @currentIdentifiers));

This seems unrelated to the async changes, what's going on here?
Comment 5 Devin Rousso 2019-12-13 10:47:29 PST
Comment on attachment 385588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385588&action=review

>> Tools/Scripts/prepare-ChangeLog:1705
>> +                my $currentFunction = join('.', (@currentScopes, ($mode eq 'class' and !$staticOrContructorSeen) ? "prototype" : "", @currentIdentifiers));
> 
> This seems unrelated to the async changes, what's going on here?

This prevents the `static async staticAsync` member function from being shown as `AsyncFuncClass.prototype.async staticAsync`, which is not accurate since the `static` means that it's not added to the `prototype`.
Comment 6 WebKit Commit Bot 2019-12-13 11:31:24 PST
Comment on attachment 385588 [details]
Patch

Clearing flags on attachment: 385588

Committed r253490: <https://trac.webkit.org/changeset/253490>
Comment 7 WebKit Commit Bot 2019-12-13 11:31:26 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-12-13 11:32:22 PST
<rdar://problem/57919141>