Bug 205176 - Fix missing exception in JSValue::toWTFStringSlowCase().
Summary: Fix missing exception in JSValue::toWTFStringSlowCase().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-12 13:19 PST by Mark Lam
Modified: 2019-12-12 17:12 PST (History)
7 users (show)

See Also:


Attachments
proposed patch. (7.40 KB, patch)
2019-12-12 13:40 PST, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-12-12 13:19:50 PST
Also fix all the new exception check failures that fall out of change.  Also replaced some ASSERTs with EXCEPTION_ASSERT so that we can run the exception check validation on a release build.

<rdar://problem/57871899>
Comment 1 Mark Lam 2019-12-12 13:40:14 PST
Created attachment 385543 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2019-12-12 13:45:29 PST
Comment on attachment 385543 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2019-12-12 17:12:59 PST
Thanks for the review.  Landed in r253458: <http://trac.webkit.org/r253458>.