Bug 205169 – SecurityOrigin should be unique for null blob URLs that have been unregistered

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[youenn fablet]

SecurityOrigin should be unique for null blob URLs that have been unregistered

[youenn fablet]

Created attachment 385504 [details]
Patch

[youenn fablet]

Created attachment 385513 [details]
Patch

[youenn fablet]

Created attachment 385518 [details]
Patch

[youenn fablet]

Created attachment 385598 [details]
Patch

[youenn fablet]

<rdar://problem/57827825>

[youenn fablet]

Created attachment 385601 [details]
Patch

[Darin Adler]

Comment on attachment 385601 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385601&action=review

> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:166
> +    if (!url.protocolIsBlob() || BlobURL::getOrigin(url) != "null")
> +        return nullptr;

Seems like the special name "null" should be gotten from calling a function rather than a hardcoded string constant.

[youenn fablet]

Created attachment 385739 [details]
Patch for landing

[youenn fablet]

(In reply to Darin Adler from comment #7)
> Comment on attachment 385601 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385601&action=review
> 
> > Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:166
> > +    if (!url.protocolIsBlob() || BlobURL::getOrigin(url) != "null")
> > +        return nullptr;
> 
> Seems like the special name "null" should be gotten from calling a function
> rather than a hardcoded string constant.

I introduced a helper routine isBlobURLContainsNullOrigin.

[WebKit Commit Bot]

Comment on attachment 385739 [details]
Patch for landing

Clearing flags on attachment: 385739

Committed r253544: <https://trac.webkit.org/changeset/253544>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.