RESOLVED FIXED 205166
[CMake] Use builtin targets 
https://bugs.webkit.org/show_bug.cgi?id=205166
Summary [CMake] Use builtin targets
Don Olmstead
Reported 2019-12-12 09:11:18 PST
We currently use builtin Find modules for the following cURL ICU Freetype LibXml2 LibXslt JPEG OpenSSL PNG Threads ZLIB With version 3.10 of CMake the following targets are available ICU::<C> Freetype::Freetype OpenSSL::<C> PNG::PNG Threads::Threads ZLIB::ZLIB Use those available.
Attachments
WIP Patch (15.13 KB, patch)
2019-12-12 10:17 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (17.63 KB, patch)
2019-12-12 11:35 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (19.55 KB, patch)
2019-12-12 11:55 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (19.59 KB, patch)
2019-12-12 12:31 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (19.67 KB, patch)
2019-12-12 12:44 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (19.62 KB, patch)
2019-12-12 12:47 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (19.92 KB, patch)
2019-12-12 15:02 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (21.60 KB, patch)
2020-02-14 13:19 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (22.00 KB, patch)
2020-02-14 13:24 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (22.15 KB, patch)
2020-02-14 13:30 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (22.12 KB, patch)
2020-02-14 13:46 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (28.10 KB, patch)
2020-02-14 14:27 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-12-12 10:17:45 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2019-12-12 11:35:45 PST Comment hidden (obsolete)
Don Olmstead
Comment 3 2019-12-12 11:55:09 PST Comment hidden (obsolete)
Don Olmstead
Comment 4 2019-12-12 12:31:51 PST Comment hidden (obsolete)
Don Olmstead
Comment 5 2019-12-12 12:44:56 PST Comment hidden (obsolete)
Don Olmstead
Comment 6 2019-12-12 12:47:39 PST Comment hidden (obsolete)
Don Olmstead
Comment 7 2019-12-12 15:02:46 PST Comment hidden (obsolete)
Don Olmstead
Comment 8 2020-02-14 13:19:11 PST Comment hidden (obsolete)
Don Olmstead
Comment 9 2020-02-14 13:24:11 PST Comment hidden (obsolete)
Don Olmstead
Comment 10 2020-02-14 13:30:35 PST Comment hidden (obsolete)
Don Olmstead
Comment 11 2020-02-14 13:46:55 PST Comment hidden (obsolete)
Don Olmstead
Comment 12 2020-02-14 14:27:53 PST
Created attachment 390820 [details] Patch
Darin Adler
Comment 13 2020-02-16 16:15:59 PST
Comment on attachment 390820 [details] Patch While I am not an expert on our use of CMake, this all looks good and EWS shows no problems with it
Adrian Perez
Comment 14 2020-02-17 00:48:49 PST
Comment on attachment 390820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390820&action=review LGTM as well, this is great! =) > Source/cmake/OptionsPlayStation.cmake:-119 > - Great to see these removals, now that CMake will track indirect dependencies itself thanks to using targets 🙌 > Source/cmake/WebKitFindPackage.cmake:6 > +# nicer to work with. I'll be looking forward to simplify this file further after we can update to a version of CMake newer than 3.10, but at least the trickery is contained in this .cmake file so that's great.
WebKit Commit Bot
Comment 15 2020-02-17 07:37:43 PST
Comment on attachment 390820 [details] Patch Clearing flags on attachment: 390820 Committed r256731: <https://trac.webkit.org/changeset/256731>
WebKit Commit Bot
Comment 16 2020-02-17 07:37:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.