Bug 205152 - [JSC] IsoHeapCellType should have destroy function member instead of specializing template function
Summary: [JSC] IsoHeapCellType should have destroy function member instead of speciali...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-11 19:54 PST by Yusuke Suzuki
Modified: 2019-12-12 01:36 PST (History)
13 users (show)

See Also:

Attachments
Patch (53.94 KB, patch)
2019-12-11 20:01 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (43.63 KB, patch)
2019-12-11 20:11 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-12-11 19:54:19 PST 
[JSC] IsoHeapCellType should have destroy function member instead of specializing template function
Comment 1 Yusuke Suzuki 2019-12-11 20:01:53 PST 
Created attachment 385473 [details]
Patch
Comment 2 Yusuke Suzuki 2019-12-11 20:11:03 PST 
Created attachment 385474 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2019-12-11 20:11:30 PST 
<rdar://problem/57865102>
Comment 4 Saam Barati 2019-12-11 21:15:03 PST 
Comment on attachment 385474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385474&action=review

> Source/JavaScriptCore/heap/IsoHeapCellType.cpp:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

2019?

> Source/JavaScriptCore/inspector/PerGlobalObjectWrapperWorld.cpp:31
> +using namespace JSC;

Why all of these?
Comment 5 Yusuke Suzuki 2019-12-12 01:35:43 PST 
Comment on attachment 385474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385474&action=review

>> Source/JavaScriptCore/heap/IsoHeapCellType.cpp:2
>> + * Copyright (C) 2017 Apple Inc. All rights reserved.
> 
> 2019?

Fixed.

>> Source/JavaScriptCore/inspector/PerGlobalObjectWrapperWorld.cpp:31
>> +using namespace JSC;
> 
> Why all of these?

ChangeLog describes the reason :)

This patch also removes `using namespace JSC;` in global code in JavaScriptCore except for API codes, since
it starts causing build failure due to unified builds: API defines JSType enum in a global scope, which is
different from our JSC::JSType. If we do `using namespace JSC;` in a global scope, it can lead to ambiguity of
looking up.
Comment 6 Yusuke Suzuki 2019-12-12 01:36:18 PST 
Committed r253423: <https://trac.webkit.org/changeset/253423>