Bug 205152 – [JSC] IsoHeapCellType should have destroy function member instead of specializing template function

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] IsoHeapCellType should have destroy function member instead of specializing template function

[Yusuke Suzuki]

Created attachment 385473 [details]
Patch

[Yusuke Suzuki]

Created attachment 385474 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/57865102>

[Saam Barati]

Comment on attachment 385474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385474&action=review

> Source/JavaScriptCore/heap/IsoHeapCellType.cpp:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

2019?

> Source/JavaScriptCore/inspector/PerGlobalObjectWrapperWorld.cpp:31
> +using namespace JSC;

Why all of these?

[Yusuke Suzuki]

Comment on attachment 385474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385474&action=review

>> Source/JavaScriptCore/heap/IsoHeapCellType.cpp:2
>> + * Copyright (C) 2017 Apple Inc. All rights reserved.
> 
> 2019?

Fixed.

>> Source/JavaScriptCore/inspector/PerGlobalObjectWrapperWorld.cpp:31
>> +using namespace JSC;
> 
> Why all of these?

ChangeLog describes the reason :)

This patch also removes `using namespace JSC;` in global code in JavaScriptCore except for API codes, since
it starts causing build failure due to unified builds: API defines JSType enum in a global scope, which is
different from our JSC::JSType. If we do `using namespace JSC;` in a global scope, it can lead to ambiguity of
looking up.

[Yusuke Suzuki]

Committed r253423: <https://trac.webkit.org/changeset/253423>