Bug 205145 - IndexedDB: make WebIDBServer a MessageReceiver to replace WebIDBConnection
Summary: IndexedDB: make WebIDBServer a MessageReceiver to replace WebIDBConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-11 16:48 PST by Sihui Liu
Modified: 2019-12-12 16:11 PST (History)
10 users (show)

See Also:

Attachments
Patch (60.62 KB, patch)
2019-12-11 16:53 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (61.03 KB, patch)
2019-12-12 15:11 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-12-11 16:48:59 PST 
...
Comment 1 Sihui Liu 2019-12-11 16:53:37 PST 
Created attachment 385459 [details]
Patch
Comment 2 Sihui Liu 2019-12-11 17:03:45 PST 
Comment on attachment 385459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385459&action=review

> Source/WebKit/ChangeLog:61
> +        (WebKit::NetworkConnectionToWebProcess::establishIDBConnectionToServer): Deleted.

NetworkConnectionToWebProcess::establishIDBConnectionToServer was used to ensure WebIDBConnectionToCilent member exists in NetworkConnectionToWebProcess. 

Now WebIDBConnectionToCilent is created in WebIDBServer::addConnection(when NetworkConnectionToWebProcess is created), so we don't need the message to do initialization.
Comment 3 Sihui Liu 2019-12-12 15:11:01 PST 
Created attachment 385555 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-12-12 16:10:15 PST 
Comment on attachment 385555 [details]
Patch for landing

Clearing flags on attachment: 385555

Committed r253452: <https://trac.webkit.org/changeset/253452>
Comment 5 WebKit Commit Bot 2019-12-12 16:10:17 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-12-12 16:11:23 PST 
<rdar://problem/57895777>