Bug 205141 - WebGLRenderingContext.texImage2D() should respect EXIF orientation
Summary: WebGLRenderingContext.texImage2D() should respect EXIF orientation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-11 15:39 PST by Said Abou-Hallawa
Modified: 2019-12-16 21:36 PST (History)
12 users (show)

See Also:

Attachments
Patch (16.41 KB, patch)
2019-12-11 15:44 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (29.78 KB, patch)
2019-12-16 15:34 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (30.50 KB, patch)
2019-12-16 17:36 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-12-11 15:39:14 PST 
If the EXIF orientation is present in an Image, WebGLRenderingContext.texImage2D() needs to draw this image into an ImageBuffer, makes a temporary Image object from the ImageBuffer then draw this temporary image to the WebGL texture. Drawing an image to an ImageBuffer respects the EXIF orientation of the original image. WebGLRenderingContext also does the same trick when drawing an SVGImage.
Comment 1 Said Abou-Hallawa 2019-12-11 15:44:34 PST 
Created attachment 385453 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-12-11 15:46:43 PST 
<rdar://problem/57370489>
Comment 3 Said Abou-Hallawa 2019-12-16 15:34:19 PST 
Created attachment 385821 [details]
Patch
Comment 4 Said Abou-Hallawa 2019-12-16 17:36:33 PST 
Created attachment 385838 [details]
Patch
Comment 5 Maciej Stachowiak 2019-12-16 19:05:02 PST 
Comment on attachment 385838 [details]
Patch

r=me
Comment 6 Maciej Stachowiak 2019-12-16 19:05:32 PST 
(Looks like Simon reviewed already so never mind.)
Comment 7 WebKit Commit Bot 2019-12-16 21:36:22 PST 
Comment on attachment 385838 [details]
Patch

Clearing flags on attachment: 385838

Committed r253610: <https://trac.webkit.org/changeset/253610>
Comment 8 WebKit Commit Bot 2019-12-16 21:36:24 PST 
All reviewed patches have been landed.  Closing bug.