Bug 205140 - REGRESSION (r172814): Don't export inline SQLiteDatabase::disableThreadingChecks() method
Summary: REGRESSION (r172814): Don't export inline SQLiteDatabase::disableThreadingChe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-11 15:37 PST by David Kilzer (:ddkilzer)
Modified: 2019-12-12 15:10 PST (History)
5 users (show)

See Also:

Attachments
Patch v1 (1.39 KB, patch)
2019-12-11 15:41 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2019-12-11 15:37:53 PST 
This is wrong in Source/WebCore/platform/sql/SQLiteDatabase.h

#ifndef NDEBUG
    WEBCORE_EXPORT void disableThreadingChecks();
#else
    WEBCORE_EXPORT void disableThreadingChecks() {}
#endif

The inline method should not have the WEBCORE_EXPORT macro.

Regressed in r172814 for Bug 136108.

Found when compiling WebKit with Release configuration and compiler optimizations disabled.
Comment 1 David Kilzer (:ddkilzer) 2019-12-11 15:41:23 PST 
Created attachment 385452 [details]
Patch v1
Comment 2 WebKit Commit Bot 2019-12-12 15:09:56 PST 
Comment on attachment 385452 [details]
Patch v1

Clearing flags on attachment: 385452

Committed r253445: <https://trac.webkit.org/changeset/253445>
Comment 3 WebKit Commit Bot 2019-12-12 15:09:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-12-12 15:10:48 PST 
<rdar://problem/57893755>