WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
205137
Remove unused Frame parameter from moveByGranularityRespectingWordBoundary() and take const VisiblePosition&
https://bugs.webkit.org/show_bug.cgi?id=205137
Summary
Remove unused Frame parameter from moveByGranularityRespectingWordBoundary() ...
Daniel Bates
Reported
2019-12-11 14:30:14 PST
moveByGranularityRespectingWordBoundary() is passed a Frame&, which it does not use, and a non-const VisiblePosition to move from, which it does not mutate. Remove the unused Frame param and take the visible position as a const lvalue reference.
Attachments
Patch
(3.03 KB, patch)
2019-12-11 14:32 PST
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2019-12-11 14:32:29 PST
Created
attachment 385440
[details]
Patch
Daniel Bates
Comment 2
2019-12-11 15:45:30 PST
Comment on
attachment 385440
[details]
Patch Clearing flags on attachment: 385440 Committed
r253400
: <
https://trac.webkit.org/changeset/253400
>
Daniel Bates
Comment 3
2019-12-11 15:45:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4
2019-12-11 15:46:38 PST
<
rdar://problem/57857274
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug