Bug 205137 - Remove unused Frame parameter from moveByGranularityRespectingWordBoundary() and take const VisiblePosition&
Summary: Remove unused Frame parameter from moveByGranularityRespectingWordBoundary() ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2019-12-11 14:30 PST by Daniel Bates
Modified: 2019-12-11 15:46 PST (History)
2 users (show)

See Also:

Patch (3.03 KB, patch)
2019-12-11 14:32 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-12-11 14:30:14 PST
moveByGranularityRespectingWordBoundary() is passed a Frame&, which it does not use, and a non-const VisiblePosition to move from, which it does not mutate. Remove the unused Frame param and take the visible position as a const lvalue reference.
Comment 1 Daniel Bates 2019-12-11 14:32:29 PST
Created attachment 385440 [details]
Comment 2 Daniel Bates 2019-12-11 15:45:30 PST
Comment on attachment 385440 [details]

Clearing flags on attachment: 385440

Committed r253400: <https://trac.webkit.org/changeset/253400>
Comment 3 Daniel Bates 2019-12-11 15:45:31 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-12-11 15:46:38 PST